From: Valdis.Kletnieks@vt.edu
To: Christer Weinigel <christer@weinigel.se>
Cc: Andy Whitcroft <apw@uk.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] teach checkpatch.pl about list_for_each
Date: Sun, 02 Dec 2007 14:47:52 -0500 [thread overview]
Message-ID: <18063.1196624872@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sun, 02 Dec 2007 13:03:35 +0100." <20071202130335.690a8daf@cw05lap>
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
On Sun, 02 Dec 2007 13:03:35 +0100, Christer Weinigel said:
> WARNING: no space between function name and open parenthesis '('
> #520: FILE: drivers/spi/spi_s3c24xx_dma.c:478:
> + list_for_each_entry (transfer, &message->transfers, transfer_list) {
>
> which I think is a bit bogus since it actually is a for statement in
> disguise.
That's how it's *implemented*. I obviously studied too much Lisp as an
undergrad, I keep thinking of list_for_* helpers as functions that take a
lambda-expression as input. In which case, it's a function and no blank is used.
:)
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next prev parent reply other threads:[~2007-12-02 19:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 12:03 Christer Weinigel
2007-12-02 13:24 ` Arnaldo Carvalho de Melo
2007-12-02 19:47 ` Valdis.Kletnieks [this message]
2008-01-03 11:10 ` Andy Whitcroft
2008-01-03 12:26 ` Christoph Hellwig
2008-01-03 12:30 ` Arnaldo Carvalho de Melo
2008-01-03 15:17 ` Benny Halevy
2008-01-03 23:12 ` Christer Weinigel
2008-01-03 11:23 ` pHilipp Zabel
2008-01-03 12:34 ` Tomas Carnecky
2008-01-03 23:10 ` Christer Weinigel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18063.1196624872@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=apw@uk.ibm.com \
--cc=christer@weinigel.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®