From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbcGKLMa (ORCPT ); Mon, 11 Jul 2016 07:12:30 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:55380 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbcGKLM3 (ORCPT ); Mon, 11 Jul 2016 07:12:29 -0400 From: Arnd Bergmann To: Krzysztof Kozlowski Cc: Rob Herring , Kefeng Wang , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Date: Mon, 11 Jul 2016 13:15:11 +0200 Message-ID: <1807726.lxvlsY5ymW@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <57710F1F.8090304@samsung.com> References: <20160627110303.3391769-1-arnd@arndb.de> <57710F1F.8090304@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:gll3KJSiC21ahoSEpzeazT/0cZ/iC8FUMnMWSNgR8tNiinxBz3B Dzi+sQBPntM3j/xROwDg5NMAv+7ufTKAPzYbpjDppomx33fYdjo8ioaqophOfbz0Tm/1wKn yO9XDNZS2vftNySa+7+KvPWJZJGHgkLKn57ngaeATfcDDYheyZdQSaCQgvexaYRGNAiXFh0 YuM1A8jbUm0mI7qKeZwiA== X-UI-Out-Filterresults: notjunk:1;V01:K0:1tZdNr2Gjo8=:3fmBtywUJB0Vc49YUkX99F 79zW5WEz8B7CPb08D+X6TY5yLAZ56bS5GPJIIc5IAeAHbTvH7kESmV3/p2SHnySkzq9gnk8dL cRm6LtQVUrJ3tbBG6NUFdi9NuNL4ZheAFfRQ+quIIft1jKS4i1TPC4PNFIxTx+6Msni5HbPFI LX1oeEjXaaGKmRej2zdHf519a19wFcyaJB0sq/s0QlKceG1PTr1KLd15lPCRxnTD2MsqQI3oF UM80vUcBTFGoFdF+iUi0HLqnyWUmFGT3vSR+gcaZ6BrZWHJnAFhpeSAksh8MQ/3c/RBgGPhnS zl83bLzu74AnHc/PfyQm/P2uYgc30P3FdT4wD6W3rN1e5FZKHcbGLORztB4VNP0e5bKEZ6va/ JVgpAstzO8RcXKtam7g79HU9muHa5Bqca29myPXRuC7LYgIx7XgZsJzohnr5nBt8SwCN2Y8tj oKeo4zAyPRIRfrqiUjUV8m6A7mYb1W4XbqWc+YUPYEqEq2PhLtAUXVfEeKIY4lPd6ce408fgN zacMSJGpG6dAd04XTe7WL5mL/Teml6bTL6HGX0hjcDJOJLXhzvChovLVRnVM1+dmczJmYXAsr jhjPsuG/Gd4EBczd6kfjczGsHAjZOnqyLQlI1iTL7lnljdxKk91CL4BnMfXS/mmkFqVnSp8Lr gLZlasJdlKvqWl3xLvW/u5PnRumysPhx4PKBYM8qF/9mw1rsBwEjBpqxzT2jGwZbhhq7MlBGG vWFSMP7cbKe6bdMs Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, June 27, 2016 1:33:51 PM CEST Krzysztof Kozlowski wrote: > On 06/27/2016 01:02 PM, Arnd Bergmann wrote: > > The change to simplify of_platform_populate() had an unintended > > side-effect of introducing a build warning on s3c64xx: > > > > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0: > > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > > > This adds a forward-declaration for the structure name in the > > header to avoid the warning. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table") > > --- > > Rob, can you apply this on top of the devicetree git so we don't > > have to coordinate the merges? > > Acked-by: Krzysztof Kozlowski Hi Rob, I still get the warning in every linux-next build, do you plan to pick up the fix for the commit you merged, or should I try to work around it in arm-soc and leave this as a bisection problem? Arnd