From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756591AbXGZATR (ORCPT ); Wed, 25 Jul 2007 20:19:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752413AbXGZAS7 (ORCPT ); Wed, 25 Jul 2007 20:18:59 -0400 Received: from [12.38.223.190] ([12.38.223.190]:28445 "EHLO mail.sw.starentnetworks.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751399AbXGZAS6 (ORCPT ); Wed, 25 Jul 2007 20:18:58 -0400 X-Greylist: delayed 1766 seconds by postgrey-1.27 at vger.kernel.org; Wed, 25 Jul 2007 20:18:58 EDT MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18087.57717.495366.413571@zeus.sw.starentnetworks.com> Date: Wed, 25 Jul 2007 19:49:09 -0400 From: Dave Johnson To: netdev@vger.kernel.org, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, lksctp-developers@lists.sourceforge.net, "Srinivas Akkipeddi" Subject: [PATCH] IPv6: ipv6_addr_type() doesn't know about RFC4193 addresses X-Mailer: VM 7.17 under 21.4 (patch 17) "Jumbo Shrimp" XEmacs Lucid Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org ipv6_addr_type() doesn't check for 'Unique Local IPv6 Unicast Addresses' (RFC4193) and returns IPV6_ADDR_RESERVED for that range. SCTP uses this function and will fail bind() and connect() calls that use RFC4193 addresses, SCTP will also ignore inbound connections from RFC4193 addresses if listening on IPV6_ADDR_ANY. There may be other users of ipv6_addr_type() that could also have problems. Signed-off-by: Dave Johnson Cc: Srinivas Akkipeddi ===== net/ipv6/addrconf_core.c 1.2 vs edited ===== --- 1.2/net/ipv6/addrconf_core.c 2007-02-26 14:42:57 -05:00 +++ edited/net/ipv6/addrconf_core.c 2007-07-25 15:21:41 -04:00 @@ -50,6 +50,9 @@ if ((st & htonl(0xFFC00000)) == htonl(0xFEC00000)) return (IPV6_ADDR_SITELOCAL | IPV6_ADDR_UNICAST | IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_SITELOCAL)); /* addr-select 3.1 */ + if ((st & htonl(0xFE000000)) == htonl(0xFC000000)) + return (IPV6_ADDR_UNICAST | + IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_GLOBAL)); /* RFC 4193 */ if ((addr->s6_addr32[0] | addr->s6_addr32[1]) == 0) { if (addr->s6_addr32[2] == 0) {