From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D97C18E5B for ; Mon, 16 Mar 2020 14:24:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DDE9206E2 for ; Mon, 16 Mar 2020 14:24:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ItMBMGoP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731513AbgCPOYr (ORCPT ); Mon, 16 Mar 2020 10:24:47 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:58305 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731492AbgCPOYr (ORCPT ); Mon, 16 Mar 2020 10:24:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584368686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8RPanWQj7akCZRE0rKGpc838ieDndaq2JCNq0zCn4Pw=; b=ItMBMGoPrTm/MxUc6fXqxs+8vT8lmAJOpjlI6GSfMOkaYQZyrA2rbXmgtVmvG80czEUTff c2Daudp0SwUxoepqRA2RThbcPCJZAqpR/cU7ELm7IdgJcbW9PXesag7iZf9fmyBCUSzpc+ +cz//4Rlw+e9F2zS21CLmlJzDkBtfOU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-seELQGmgNhqXzPmviVCfpg-1; Mon, 16 Mar 2020 10:24:42 -0400 X-MC-Unique: seELQGmgNhqXzPmviVCfpg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B759800D53; Mon, 16 Mar 2020 14:24:40 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-182.rdu2.redhat.com [10.10.120.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2D1A910246E3; Mon, 16 Mar 2020 14:24:33 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200313152102.1707-4-longman@redhat.com> References: <20200313152102.1707-4-longman@redhat.com> <20200313152102.1707-1-longman@redhat.com> To: Waiman Long Cc: dhowells@redhat.com, Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , Mimi Zohar , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, Sumit Garg , Jerry Snitselaar , Roberto Sassu , Eric Biggers , Chris von Recklinghausen Subject: Re: [PATCH v3 3/3] KEYS: Use kvmalloc() to better handle large buffer allocation MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1809106.1584368672.1@warthog.procyon.org.uk> Date: Mon, 16 Mar 2020 14:24:32 +0000 Message-ID: <1809107.1584368672@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I wonder if it's worth merging this into patch 2. I'm not sure it's really worth its own patch. If you want to generalise kvzfree(), then that could go as its own patch first. David