From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5703D340D8C for ; Tue, 27 Jan 2026 10:32:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769509947; cv=none; b=bClBjTrKRMUWLDl5qysHIE8sXEqMronMdGeRZb8x5pTAL1m8D3MunSCZGa0L6sc3PGJUAYM8JTxjalcuxmhlFf5V0uS9VHvhJAoqrAOIzoYBaBRytBitF/J2Q9VtJKeyso257ngMGCvmDBvQDgzUxGa6/hkcFTcAX75MLqK5cLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769509947; c=relaxed/simple; bh=qwyJU5OEksPKCmMqCF9hGD/eIHdz0/qHgr5yw1aSdOI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PBPJE+F6RPd87NuEMl56veMoojxujhj+w3IedFfbS6Cgt/rDzu8qc9FJ4Emfl4lm0lKjbgTs5Rf3dpwKnjk8ifKe0bHf7B3v3ITf4JuhqilIWCYQYAKGBOGAaSlVzozeDAnfeh5Ao0UPAcXDDZV6IhqpnQrWxZYiEQNUl1dqbbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dtyHl2Ew; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WFDcJpzn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dtyHl2Ew"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WFDcJpzn" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60R9vtfN3858436 for ; Tue, 27 Jan 2026 10:32:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4vfcCrO11hLSQ7AmKAqjdnGN/XAneF5vhpmb7O0mZ9M=; b=dtyHl2EwYjnSGDY1 op/tKu0f6EGKlGwMX2zTNgOpJN+h7S2fQ+dbx8V0D63kzEtWu2lw6b/Ur15voN2p fnR9iQRBpxtyJdBhp/yBH6jKrcQADNKb8Zzthnasim/1cOc/af9dZnQwcHCEGMzB ZA5Bq5QauM3GedKd49IuVwa6kO9hNb3O55I6eBKxYvfQPko3y2KCYvCetTwVWXvK Htc+HbtDyas8jhDN5pzDOxF0YefYXGF0zn7ZWMk7RKYIApVqfUcoAb+54OHfvmk7 pRSqkQmi7adqrBPG/CWSRQuwac+Fk4yqM6iB0VAvFwKBURZVvifSDbDeL2eKJ0dI QQiL3g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxffs2b4t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 10:32:25 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c536c9d2f7so182010685a.1 for ; Tue, 27 Jan 2026 02:32:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769509945; x=1770114745; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4vfcCrO11hLSQ7AmKAqjdnGN/XAneF5vhpmb7O0mZ9M=; b=WFDcJpznZPCRjRvK/joqoto8MxZpfo8OHc1zJs6lnajfieIKzS8bCVFlyED7n6dcPq no+J4DhcG5ddCyAPVJcK1Kw5DfJS5G4CGCphjA96yT2Dq0u+twyNP+OiQ9in9LY6u9W+ hjoBQzKIblBpBVoaRCDMFXv12xH2ZLFrMxCf0InyAnjNel0xgt7LPjPsxQWP//DoQHOw +X1IgsEfDm++ORlxUFs8iq5K3N5rsO6uTMs5a+aeK95xcQm6mUd3dy9A3gebqqD413rI GkfM2IQpP4mwWXlrPds/4AWbnB30wTQEAIzs0lR5shRxcdv7fAj6dpP2fHb0o0phkcBu fMwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769509945; x=1770114745; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4vfcCrO11hLSQ7AmKAqjdnGN/XAneF5vhpmb7O0mZ9M=; b=Jmi2LjxHafrBpDdZne8UNd1fq0pu5gtAivxGwS5hyUGOLv1FcOYU07U37EJqLWrtTH srp93X8S2QLETRUUuuCSEGhL3ZOa1eLzLdd5KfbZmhkAYn7H8aiAjJd9nAX7ebqucBb+ oBgd5+Zsjuhzsnxpg+rSZv3neWGSUyS2u0MS+QwsEJ9IixSA3It7l8YrhaQctjUSL0M5 owlIKWSlbKLRmY2C7gl9LMpPGnkLG5JJ8AEN0yVtDkcVq2xZ8QwFokTWFR8obdSgMpZS fCLvubQIFUVbX2ioF0CveCsf61XjsLmog9lUsgZh4C6eXrKzoUCWM45Zf7MxQdI52gw/ Uh+g== X-Gm-Message-State: AOJu0YzZSI6e/oE+wQQWfw0Nlw1hwUfA8oH0SiTGMCTtnzDwoLKpDlpD 1nuURqDOK+OyZxHSRV3VAJVn7QCW4/bCfZXryQJgbG61KhvDBu+DMCY2D/12y0rtwgOtFewgOSs hp25IL7ksNyAkJU2BrG/ux8nOio7gacHzXjzs7KSWjuf00jD/T1Lp+5/eXAiuDKtMtpw= X-Gm-Gg: AZuq6aJmQiiIe/KcsknLqDqaTGJb6886tA615wL4n0wuoZrLyDKSRn8vdFUsYyk8Ib7 NJ50ykFvkUExuyvZcLYf9eXbCcyMFK/McwGQj8Ca8ncEjURWcbigeaCteaBaH7pLiJBRJ9nKDIk LE6Uw8uuviufKibVLOQdJ+/TEBl5m7MniC2RNSfD/Qqe8n4zEIlWyjQnVa9aOnyhPqc+R0sJEZq jYtl0jN92B4/Y8WowfboOxfGo6RH6qsQPq6L5/rraL0ImdwF3jsrwWoKrh7QPhKQHiZ2ilo/EnM Upz6QZabmti4ByekanCgwEQOd72PSnfbZMRNrSCfwxMD+vDmelQMD88ENsNt8PJOY/U1vRS9xrO TVSjyyk7LbJcekk4/GqETuALLaQxnYyqyfrBPjtsXOdqH064aUwZWz4Dw+wDE+HIP2Xo= X-Received: by 2002:a05:620a:3199:b0:8b9:fa81:5282 with SMTP id af79cd13be357-8c70b91afdemr91631185a.3.1769509944790; Tue, 27 Jan 2026 02:32:24 -0800 (PST) X-Received: by 2002:a05:620a:3199:b0:8b9:fa81:5282 with SMTP id af79cd13be357-8c70b91afdemr91629685a.3.1769509944389; Tue, 27 Jan 2026 02:32:24 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b885b6ff080sm742606766b.38.2026.01.27.02.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 02:32:23 -0800 (PST) Message-ID: <18099460-bd1b-433f-b700-1cdac65273e8@oss.qualcomm.com> Date: Tue, 27 Jan 2026 11:32:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 5/7] qcom-tgu: Add support to configure next action To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20260109021141.3778421-1-songwei.chai@oss.qualcomm.com> <20260109021141.3778421-6-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 28xwGc24lYo4_4sLpSRXJZAhTk109pPh X-Authority-Analysis: v=2.4 cv=YpcChoYX c=1 sm=1 tr=0 ts=69789439 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=8YFCAo1tzF019N3mk9oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: 28xwGc24lYo4_4sLpSRXJZAhTk109pPh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDA4NSBTYWx0ZWRfX5RGB7raJgZzb TgE7L2cZqJCQF8mgDJsPuaHHN6k2jphz19oMd/fIIimqddm/Yg7IBzYbGkVLotWy6F6ymV5L8zU NQvza54aRufyq/Aj+LQkhRGMQv/qzjKyIoJa71kRtj0KJj4ThsIynHaXVL0aYJYWg2zpFdQYSs9 7IjmLcAC7LcCDHXZrqdfiaU2UT7WkHYokntNCjrGqB9yBHvO9VifLsunMos1a/s4N+xeNnelwmi kL2baRt0/sWQ/Jz35o3ROlJ7SXDmJjHFOBm8vp980FLtREiLFpLaFVXDV2sFfQZlcZ+c+oE43a1 OLMohwHKx/wFQcA30pQeheesVhKswLeETXwSCH5HEhmVBqgt0vgdT5MH9yqhHCJopGOOkwIYWe7 eomTTYiSVwnp71fct+OlP4BccpEvVPnjSj5ccDuR6l06dnDjDEwzfkL2BsE5i7bequMdtaf/WH0 8JZ9vK/cPXqstP+EPKA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-27_02,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270085 On 1/27/26 3:43 AM, Songwei Chai wrote: > > > On 1/13/2026 7:15 PM, Konrad Dybcio wrote: >> On 1/9/26 3:11 AM, Songwei Chai wrote: >>> Add "select" node for each step to determine if another step is taken, >>> trigger(s) are generated, counters/timers incremented/decremented, etc. >>> >>> Signed-off-by: Songwei Chai >>> --- [...] >>> +    select = devm_kzalloc(dev, select_size, GFP_KERNEL); >>> + >>> +    if (!select) >> >> stray \n > Will improve this based on the comments above. >> >>> +        return -ENOMEM; >>> + >>> +    drvdata->value_table->condition_select = select; >> >> I don't see a need for an intemediate variable here > > This was done intentionally, following the earlier suggestion in v9 to > introduce named intermediate variables for better readability when dealing with allocations. > > I’m happy to inline the allocation if you prefer the simpler form here. I don't mind that much Konrad