From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Noam Camus <noamca@mellanox.com>, <linux-snps-arc@lists.infradead.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 08/11] ARC: [plat-eznps] spinlock aware for MTM
Date: Fri, 2 Jun 2017 11:36:17 -0700 [thread overview]
Message-ID: <180d8e76-fa00-b138-0d5f-720b116228b8@synopsys.com> (raw)
In-Reply-To: <1495954328-28736-9-git-send-email-noamca@mellanox.com>
On 05/27/2017 11:52 PM, Noam Camus wrote:
> From: Noam Camus <noamca@mellanox.com>
>
> This way when we execute "ex" during trying to hold lock we can switch to
> other HW thread and utilize the core intead of just spinning on a lock.
>
> We noticed about 10% improvement of execution time with hackbench test.
>
> Signed-off-by: Noam Camus <noamca@mellanox.com>
> ---
> arch/arc/include/asm/spinlock.h | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arc/include/asm/spinlock.h b/arch/arc/include/asm/spinlock.h
> index 233d5ff..0a54ce7 100644
> --- a/arch/arc/include/asm/spinlock.h
> +++ b/arch/arc/include/asm/spinlock.h
> @@ -252,9 +252,15 @@ static inline void arch_spin_lock(arch_spinlock_t *lock)
>
> __asm__ __volatile__(
> "1: ex %0, [%1] \n"
> +#ifdef CONFIG_EZNPS_MTM_EXT
> + " .word %3 \n"
> +#endif
> " breq %0, %2, 1b \n"
> : "+&r" (val)
> : "r"(&(lock->slock)), "ir"(__ARCH_SPIN_LOCK_LOCKED__)
> +#ifdef CONFIG_EZNPS_MTM_EXT
> + , "i"(CTOP_INST_SCHD_RW)
> +#endif
> : "memory");
>
> /*
>
This is ugly - I will fix it up here to create an NPS version of arch_spin_lock !
-Vineet
next prev parent reply other threads:[~2017-06-02 18:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 6:51 [PATCH v2 00/11] ARC plat-eznps upstream cont Noam Camus
2017-05-28 6:51 ` [PATCH v2 01/11] ARC: set level of log per CPU during boot to be debug level Noam Camus
2017-05-28 6:51 ` [PATCH v2 02/11] ARC: send ipi to all cpus sharing task mm in case of page fault Noam Camus
2017-05-30 16:40 ` Vineet Gupta
2017-05-28 6:52 ` [PATCH v2 03/11] ARC: typo fix in mm/fault.c Noam Camus
2017-05-28 6:52 ` [PATCH v2 04/11] ARC: typos fix in kernel/entry-compact.S Noam Camus
2017-05-28 6:52 ` [PATCH v2 05/11] ARC: [plat-eznps] typo fix at Kconfig Noam Camus
2017-05-28 6:52 ` [PATCH v2 06/11] ARC: [plat-eznps] Fix TLB Errata Noam Camus
2017-05-28 6:52 ` [PATCH v2 07/11] ARC: [plat-eznps] disabled stall counter due to a HW bug Noam Camus
2017-05-29 15:15 ` Alexey Brodkin
2017-05-28 6:52 ` [PATCH v2 08/11] ARC: [plat-eznps] spinlock aware for MTM Noam Camus
2017-06-02 18:36 ` Vineet Gupta [this message]
2017-06-04 6:11 ` Noam Camus
2017-05-28 6:52 ` [PATCH v2 09/11] ARC: [plat-eznps] use schd.wft instruction instead of sleep at idle task Noam Camus
2017-05-28 6:52 ` [PATCH v2 10/11] ARC: enable platform specific mem_service implementation Noam Camus
2017-05-28 6:52 ` [PATCH v2 11/11] ARC: [plat-eznps] Handle memory error as an exception Noam Camus
2017-06-02 19:04 ` Vineet Gupta
2017-06-04 6:10 ` Noam Camus
2017-06-06 22:10 ` Vineet Gupta
2017-06-07 6:07 ` Noam Camus
2017-06-07 11:14 ` Noam Camus
2017-06-07 16:15 ` Vineet Gupta
[not found] ` <AM5PR0502MB2996A1F4CFE1FE6AEB433A7DAAC80@AM5PR0502MB2996.eurprd05.prod.outlook.com>
[not found] ` <AM5PR0502MB2996FBD57D8591A42ED4A84CAAC90@AM5PR0502MB2996.eurprd05.prod.outlook.com>
2017-06-08 16:38 ` Vineet Gupta
[not found] ` <AM5PR0502MB299646D52F2A0AF3764CEC4BAAC90@AM5PR0502MB2996.eurprd05.prod.outlook.com>
2017-06-08 19:00 ` Vineet Gupta
[not found] ` <AM5PR0502MB2996B6DA5530C4B37A7B1AF0AACE0@AM5PR0502MB2996.eurprd05.prod.outlook.com>
2017-06-12 17:40 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=180d8e76-fa00-b138-0d5f-720b116228b8@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=noamca@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®