From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752970AbdK1XRE (ORCPT ); Tue, 28 Nov 2017 18:17:04 -0500 Received: from mail-sh2.amlogic.com ([58.32.228.45]:19700 "EHLO mail-sh2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752555AbdK1XRB (ORCPT ); Tue, 28 Nov 2017 18:17:01 -0500 Subject: Re: [PATCH v3 2/3] clk: meson-axg: add clock controller drivers To: Rob Herring References: <20171128125330.363-1-yixun.lan@amlogic.com> <20171128125330.363-3-yixun.lan@amlogic.com> <20171128163022.7b7wvfqedkhhnaj6@rob-hp-laptop> CC: , Neil Armstrong , Jerome Brunet , Kevin Hilman , Mark Rutland , Michael Turquette , Stephen Boyd , Carlo Caione , Qiufang Dai , , , , , From: Yixun Lan Message-ID: <1811d609-36bc-290c-6405-80121e4de8bb@amlogic.com> Date: Wed, 29 Nov 2017 07:16:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20171128163022.7b7wvfqedkhhnaj6@rob-hp-laptop> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [58.34.187.116] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh2.amlogic.com (10.18.11.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Rob On 11/29/17 00:30, Rob Herring wrote: > On Tue, Nov 28, 2017 at 08:53:29PM +0800, Yixun Lan wrote: >> From: Qiufang Dai >> >> Add clock controller drivers for Amlogic Meson-AXG SoC. >> >> Signed-off-by: Qiufang Dai >> Signed-off-by: Yixun Lan >> --- >> arch/arm64/Kconfig.platforms | 1 + >> drivers/clk/meson/Kconfig | 8 + >> drivers/clk/meson/Makefile | 1 + >> drivers/clk/meson/axg.c | 948 +++++++++++++++++++++++++++++++++++ >> drivers/clk/meson/axg.h | 126 +++++ > >> include/dt-bindings/clock/axg-clkc.h | 72 +++ > > This belongs in the binding patch. > is it Ok to keep it in this patch? the initial idea to do this is to keep the commit bisectable.. > Otherwise, > > Acked-by: Rob Herring > > >> 6 files changed, 1156 insertions(+) >> create mode 100644 drivers/clk/meson/axg.c >> create mode 100644 drivers/clk/meson/axg.h >> create mode 100644 include/dt-bindings/clock/axg-clkc.h > > . >