From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936338AbcKXBXH (ORCPT ); Wed, 23 Nov 2016 20:23:07 -0500 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:56627 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935701AbcKXBW4 (ORCPT ); Wed, 23 Nov 2016 20:22:56 -0500 From: "Rafael J. Wysocki" To: Guenter Roeck , Mika Westerberg Cc: Vegard Nossum , Wim Van Sebroeck , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE Date: Thu, 24 Nov 2016 02:30:43 +0100 Message-ID: <1813013.KOlSoqaZE7@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.9.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1dbc6c68-3ec7-1f4b-746d-494ffba39311@roeck-us.net> References: <20161121133307.157776-1-mika.westerberg@linux.intel.com> <1dbc6c68-3ec7-1f4b-746d-494ffba39311@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, November 21, 2016 07:14:08 AM Guenter Roeck wrote: > On 11/21/2016 05:33 AM, Mika Westerberg wrote: > > The WDAT watchdog driver uses functionality provided by the watchdog timer > > core but it did not select it explicitly. This results following linker > > error when only WDAT_WDT is enabled in Kconfig: > > > > drivers/built-in.o: In function `wdat_wdt_probe': > > drivers/watchdog/wdat_wdt.c:444: undefined reference to `devm_watchdog_register_device' > > > > Fix this by explicitly selecting WATCHDOG_CORE when WDAT watchdog driver is > > enabled. > > > > Fixes: 058dfc767008 (ACPI / watchdog: Add support for WDAT hardware watchdog) > > Reported-by: Vegard Nossum > > Signed-off-by: Mika Westerberg > > Reviewed-by: Guenter Roeck > Applied. Thanks, Rafael