mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Vitaly Mayatskikh <vmayatsk@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PPC64 AT_IGNOREPPC question
Date: Mon, 10 Sep 2007 03:55:19 +1000	[thread overview]
Message-ID: <18148.13191.876031.378696@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <m3odgehs9e.fsf@dhcp-lab-156.englab.brq.redhat.com>

Vitaly Mayatskikh writes:

> include/asm-powerpc/elf.h:289
> 
> Why we need the second AT_IGNOREPPC entry here?
> 
> There is a mm_struct->saved_auxv overflow on PPC64 with AT_VECTOR_SIZE
> == 44 (may be on PPC32 too, not checked) when adding all entries to
> it. I've removed the second AT_IGNOREPCC from ARCH_DLINFO to prevent 
> overflowing, checked it on IBM OpenPower 720 and a system (Fedora 7) is 
> going on as well. Have I missed some tricky thing?

In the past, ppc32 kernels used to round up the address of the end of
the environment pointers to a multiple of 16 before writing the aux
vector, which meant that that was where userspace looked for it.  When
the rounding was removed in the kernel, we arranged to put in the two
AT_IGNOREPPC entries so that old binaries would still be able to find
the aux vector.

I'll have to check when that change was done and decide whether we can
now take out the AT_IGNOREPPC entries.  If not it sounds like we need
to expand AT_VECTOR_SIZE.

Paul.


  reply	other threads:[~2007-09-09 20:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-08  1:15 Vitaly Mayatskikh
2007-09-09 17:55 ` Paul Mackerras [this message]
2007-09-10  6:55   ` Vitaly Mayatskikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18148.13191.876031.378696@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vmayatsk@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®