From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965304AbdCVRtg (ORCPT ); Wed, 22 Mar 2017 13:49:36 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:35028 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965279AbdCVRtW (ORCPT ); Wed, 22 Mar 2017 13:49:22 -0400 X-AuditID: b6c32a35-f79d66d000001a37-34-58d2b91e1983 From: Bartlomiej Zolnierkiewicz To: Sekhar Nori Cc: Tejun Heo , Sergei Shtylyov , Kevin Hilman , Arnd Bergmann , Russell King , Dmitry Eremin-Solenikov , linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver Date: Wed, 22 Mar 2017 18:49:12 +0100 Message-id: <1819267.Nm9hpTOhuY@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <8fc9171f-15b7-2c6a-d0b5-3af21cc88405@ti.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTYRiH+c7ZuWw1OU2nb1kWg6AszYHBSSVKLA4WlWgxiqyRB9O2KZtK SRdJc2VKOu02FKUsa0TFJnlDXbO2goqmpWZlZhfD0DA11FXmPAb+97zf9/B7+X18NC6rJZbQ KboMXq9TaxSkRPSgbXVISFBDuyps6OcG9o/JSbGmzz9wdtJYi7HWT50E66zvx9iOxnKSfdsh ZVuL7mPsM0sPxU7VPEabJFxebiHJeaZMiPvRfYbi+i5OY1yD+T3FWS3nSM5WfYpzdddh3Kg1 aJd4ryQqidekZPH6dRsPSg53FQanG8VHbQ+u4znoEVWAaBqYcOh8pyxA4hn0h5e998gCJKFl TD2C27YiTBiMGIw8PE0IVjjcLjXPWTUIPAODImEYR1BR6RJ5LZKJgBKjBXnZj1kBllfNhFfC mdcYVDqrZqN8mW0w6cyjvCxiVsKbL+Wkl6XManhqeznryJlYqG0xYl4Wz4Q2WZ9QgrMIJkp7 Z5fhzHJoab1ICLwWnjvvIu8yYNopaDbZRELRZWC140KFGLjzeYQU2BcGXbWUwIFg+duDCXwZ QZ0HhBwbAktT8ZwUCW0u99wyHxgeLySEfCmczZcJCgd9HeNI4M0wlN9GCS90HoPvE42oGC03 z+tgntfBPK9DFcItyJ9PN2iTeYMyXRlqUGsNmbrk0ENpWiua/UvB6+tR2YvtDsTQSLFQqjre rpIR6izDMa0DAY0r/KS/62aOpEnqY9m8Pu2APlPDGxwokBYpAqREWIlKxiSrM/gjPJ/O6//f YrR4SQ46khAUIe+XZ57cfzWwuj8+caPcfu2X49bYp+HFUbG5S4+GdDZpnBORxz2KuIGirMoQ DWnfeuFm9p6aG13Mh6aPTLxqwZXINN2IdVR51aWYzt/pzrmk5RL2+Xw78fWJ3Q3GVWOSLe7o Nai67IM9NbUvOi4xLSAhRrLjfm/F7ufDiQqR4bBaGYzrDep/SxO2sEcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t9jAV3ZnZciDJY2a1r8nXSM3WLSk/fM Fj/btzBZbHp8jdXi2I5HTBaXd81hs7h9mddif+8GJoszq26xW/xafpTRgcujpbmHzeP3r0mM Hu9vtLJ7PJj6n8lj56y77B6bVnWyeWxeUu9x/MZ2Jo/Pm+QCOKPcbDJSE1NSixRS85LzUzLz 0m2VQkPcdC2UFPISc1NtlSJ0fUOClBTKEnNKgTwjAzTg4BzgHqykb5fglnG9R6ugnbNi87bF zA2MR9i7GDk5JARMJFZOnsUGYYtJXLi3HswWEljKKPF/mmAXIxeQ/ZVRYuKjE2AJNgEriYnt qxhBbBEBBYlVV/ayghQxC1xnktjw+R4LSEJYwFvi57EWsA0sAqoSN5/OAWvmFdCUOLn5AiuI LSrgJbFlXzsTiM0JNHT3phPsENu2M0qsn/gXqkFQ4sdkiKHMAvIS+/ZPZYWwtSTW7zzONIFR YBaSsllIymYhKVvAyLyKUSK1ILmgOCk91zAvtVyvODG3uDQvXS85P3cTIzhOn0ntYDy4y/0Q owAHoxIPb0TNpQgh1sSy4srcQ4wSHMxKIrx2W4BCvCmJlVWpRfnxRaU5qcWHGE2BPpzILCWa nA9MIXkl8YYm5ibmxgYW5paWJkZK4ryNs5+FCwmkJ5akZqemFqQWwfQxcXBKNTDOesricMB4 6USRhdl7clK4ujl2nNlcJLbjUoX6no0FQQtm/qss9mLf0C8SHtpdHK87gymta+bGk5+m2v6e 2/MqZvFqC7ZNLsuXRdSxSkx6/VvKMTC+xXvTeZm6V1MOTZsw69HOFnF5J5clNrOZEk8uL19z xditRq6Fc4r9Zt52oQ8p8gdnZKQrsRRnJBpqMRcVJwIA0sNIWOkCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170322174917epcas1p1a4ba3e4da231ee3b7784cb0c669611ed X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170322174917epcas1p1a4ba3e4da231ee3b7784cb0c669611ed X-RootMTR: 20170322174917epcas1p1a4ba3e4da231ee3b7784cb0c669611ed References: <1489509414-11491-1-git-send-email-b.zolnierkie@samsung.com> <1489509414-11491-2-git-send-email-b.zolnierkie@samsung.com> <8fc9171f-15b7-2c6a-d0b5-3af21cc88405@ti.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, March 21, 2017 02:04:38 PM Sekhar Nori wrote: > Hi, > > On Tuesday 14 March 2017 10:06 PM, Bartlomiej Zolnierkiewicz wrote: > > Add Palmchip BK3710 PATA controller driver. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > There are some checkpatch suggestions that are worth fixing, I think. > > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz - 2017-03-14 2206.eml:277: CHECK: Alignment should match open parenthesis > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz - 2017-03-14 2206.eml:320: CHECK: Alignment should match open parenthesis > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz - 2017-03-14 2206.eml:489: CHECK: Comparison to NULL could be written "!mem" Will be fixed in v3, thanks. [ My scripts didn't run checkpatch with --strict so I haven't noticed them. ] Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics