From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993063AbcBSO3X (ORCPT ); Fri, 19 Feb 2016 09:29:23 -0500 Received: from mail.eperm.de ([89.247.134.16]:34190 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993047AbcBSO3T (ORCPT ); Fri, 19 Feb 2016 09:29:19 -0500 From: Stephan Mueller To: Marcus Meissner Cc: herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: allow rfc3686 aes-ctr variants in fips mode. Date: Fri, 19 Feb 2016 15:29:30 +0100 Message-ID: <181988892.jqsYzZjG1O@positron.chronox.de> User-Agent: KMail/4.14.10 (Linux/4.3.5-300.fc23.x86_64; KDE/4.14.16; x86_64; ; ) In-Reply-To: <1455885268-15054-1-git-send-email-meissner@suse.de> References: <1455885268-15054-1-git-send-email-meissner@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 19. Februar 2016, 13:34:28 schrieb Marcus Meissner: Hi Marcus, > RFC 3686 CTR in various authenc methods. > > rfc3686(ctr(aes)) is already marked fips compliant, > so these should be fine. > > Signed-off-by: Marcus Meissner Acked-by: Stephan Mueller > --- > crypto/testmgr.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/crypto/testmgr.c b/crypto/testmgr.c > index 190a290..5316d59 100644 > --- a/crypto/testmgr.c > +++ b/crypto/testmgr.c > @@ -2167,6 +2167,10 @@ static const struct alg_test_desc alg_test_descs[] = > { } > } > }, { > + .alg = "authenc(hmac(sha1),rfc3686(ctr(aes)))", > + .test = alg_test_null, > + .fips_allowed = 1, > + }, { > .alg = "authenc(hmac(sha224),cbc(des))", > .test = alg_test_aead, > .suite = { > @@ -2239,6 +2243,10 @@ static const struct alg_test_desc alg_test_descs[] = > { .test = alg_test_null, > .fips_allowed = 1, > }, { > + .alg = "authenc(hmac(sha256),rfc3686(ctr(aes)))", > + .test = alg_test_null, > + .fips_allowed = 1, > + }, { > .alg = "authenc(hmac(sha384),cbc(des))", > .test = alg_test_aead, > .suite = { > @@ -2270,6 +2278,10 @@ static const struct alg_test_desc alg_test_descs[] = > { .test = alg_test_null, > .fips_allowed = 1, > }, { > + .alg = "authenc(hmac(sha384),rfc3686(ctr(aes)))", > + .test = alg_test_null, > + .fips_allowed = 1, > + }, { > .alg = "authenc(hmac(sha512),cbc(aes))", > .fips_allowed = 1, > .test = alg_test_aead, > @@ -2315,6 +2327,10 @@ static const struct alg_test_desc alg_test_descs[] = > { .test = alg_test_null, > .fips_allowed = 1, > }, { > + .alg = "authenc(hmac(sha512),rfc3686(ctr(aes)))", > + .test = alg_test_null, > + .fips_allowed = 1, > + }, { > .alg = "cbc(aes)", > .test = alg_test_skcipher, > .fips_allowed = 1, Ciao Stephan