From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FB3CC83F11 for ; Sat, 26 Aug 2023 09:32:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232236AbjHZJb3 (ORCPT ); Sat, 26 Aug 2023 05:31:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232223AbjHZJbR (ORCPT ); Sat, 26 Aug 2023 05:31:17 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 972BD1BD4 for ; Sat, 26 Aug 2023 02:31:14 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-99357737980so204619366b.2 for ; Sat, 26 Aug 2023 02:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693042273; x=1693647073; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EChLnWgFwtxG0VHdbqAfcg52xVSiRBXQV7i6dT2tv7c=; b=Yb99bZ4wGZxqk+slRTMR8Dxt/Cyko19x6lyUCAl3+zIEnc1KUf1Kiqm2QjayPyVbN4 vFeEIVj8PvJaeNk8KyluY1OG0UdplxyS2OaUWME8zIUwL6MCEBkjYXdD2lVJ61fu177L Ela/AVLWGDs3XRQIAqU2USlD0wHj6X2rAr/mM3G3nlDznbMtmhVeT0NWxtIyEzhaDBHv JvGvjZFQPctFSYnehZ629dyaY+ZwfTFOE5BoJY/ByFUuqw3fURUTzBzgQsdsIqgnlBCd KrJDuSoyfKnNR92I3+iVV+ZJezdyj2r7aVk3fs2hs2HXKzEM5+VY9pvbJD62foeBZFF+ YOvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693042273; x=1693647073; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EChLnWgFwtxG0VHdbqAfcg52xVSiRBXQV7i6dT2tv7c=; b=dv3/kv7/9qvsU5Jnornzexq5CpTTrJ37FW0FoQGH2DQeLfUfbXGsUgeYkcbfecxfII OpGH4P5oIoQT+r77gjIOiu8C4Y5vQWUyTbb92H7e5pxDeD8y4HAfRQptIYDZHeeSWJJi KEyCm7xccTfnKJjw0NHaqYF3QLnVhAcX46+ffbn29qzoOs0kIemVa2b3DF9RK/Vkpqnt ox7Ry8A+OuMU++10yXpr/tdWG9L1BApPvEHAZSiwx/DIUkxHg2QgP2Bi+A9XSurFWTSE 529FeFzKIAJeJEbc0TsA/9DrMSRkH6EO/4UxMkfN8m7W5gQD/Qr4HUDTR5vf7gV9dNIk 4XBA== X-Gm-Message-State: AOJu0YyDA3/wq1HDgW/SzFi+KHVG/K33Jo0ng37YxJAF+wFEkP/frFKF lk/lOFJ37IZXQSagDl2Fu0xxuA== X-Google-Smtp-Source: AGHT+IFLC+zY307Od3pUJ2Xn6CVOHUDNZckaAlPAclBJHxbKZTsMTGLOoa08s9rJeTyIXzDEwnGoqQ== X-Received: by 2002:a17:907:2bee:b0:9a1:b950:abab with SMTP id gv46-20020a1709072bee00b009a1b950ababmr9687785ejc.32.1693042273124; Sat, 26 Aug 2023 02:31:13 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id ha19-20020a170906a89300b0099c157cba46sm1914658ejb.119.2023.08.26.02.31.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Aug 2023 02:31:12 -0700 (PDT) Message-ID: <181b5ac9-25c3-539e-6bde-773e833ee9b6@linaro.org> Date: Sat, 26 Aug 2023 11:31:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/2] ASoC: codecs: lpass-tx-macro: Add SM6115 support Content-Language: en-US To: Konrad Dybcio , Srinivas Kandagatla , Banajit Goswami , Andy Gross , Bjorn Andersson , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai Cc: Marijn Suijten , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230825-topic-6115tx-v1-0-ebed201ad54b@linaro.org> <20230825-topic-6115tx-v1-2-ebed201ad54b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230825-topic-6115tx-v1-2-ebed201ad54b@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/08/2023 19:23, Konrad Dybcio wrote: > SM6115 has a TX macro, which surprisingly doesn't host a SWR master. > Conditionally skip the SWR reset sequence on this platform. > > Signed-off-by: Konrad Dybcio > --- > sound/soc/codecs/lpass-macro-common.h | 2 ++ > sound/soc/codecs/lpass-tx-macro.c | 22 +++++++++++++++------- > 2 files changed, 17 insertions(+), 7 deletions(-) > > diff --git a/sound/soc/codecs/lpass-macro-common.h b/sound/soc/codecs/lpass-macro-common.h > index 4eb886565ea3..d3684c7ab930 100644 > --- a/sound/soc/codecs/lpass-macro-common.h > +++ b/sound/soc/codecs/lpass-macro-common.h > @@ -8,6 +8,8 @@ > > /* NPL clock is expected */ > #define LPASS_MACRO_FLAG_HAS_NPL_CLOCK BIT(0) > +/* The soundwire block should be internally reset at probe */ > +#define LPASS_MACRO_FLAG_RESET_SWR BIT(1) > > struct lpass_macro { > struct device *macro_pd; > diff --git a/sound/soc/codecs/lpass-tx-macro.c b/sound/soc/codecs/lpass-tx-macro.c > index 3e33418898e8..82f9873ffada 100644 > --- a/sound/soc/codecs/lpass-tx-macro.c > +++ b/sound/soc/codecs/lpass-tx-macro.c > @@ -2045,15 +2045,19 @@ static int tx_macro_probe(struct platform_device *pdev) > if (ret) > goto err_fsgen; > > + Stray link line. Rest looks good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof