From: Markus Elfring <Markus.Elfring@web.de>
To: make24@iscas.ac.cn, dri-devel@lists.freedesktop.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Anitha Chrisanthus <anitha.chrisanthus@intel.com>,
David Airlie <airlied@gmail.com>,
Edmund Dea <edmund.j.dea@intel.com>,
Sam Ravnborg <sam@ravnborg.org>, Simona Vetter <simona@ffwll.ch>
Subject: Re: [PATCH] drm/kmb: Fix error handling in kmb_probe
Date: Mon, 17 Nov 2025 16:18:01 +0100 [thread overview]
Message-ID: <1822671a-5f10-43b1-b678-04f47752cd29@web.de> (raw)
In-Reply-To: <20251117075708.37414-1-make24@iscas.ac.cn>
…
> Add put_device() in all code paths where dsi_pdev is no longer needed,
> including error paths and the normal removal path.
How do you think about to apply the attribute “__free(put_device)”?
https://elixir.bootlin.com/linux/v6.18-rc5/source/include/linux/device.h#L1183
By the way:
I propose to avoid duplicate of_node_put() calls in this function implementation.
Would it be helpful to append parentheses to the function name in the summary phrase?
Regards,
Markus
prev parent reply other threads:[~2025-11-17 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 7:57 Ma Ke
2025-11-17 15:18 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1822671a-5f10-43b1-b678-04f47752cd29@web.de \
--to=markus.elfring@web.de \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anitha.chrisanthus@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=sam@ravnborg.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®