From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753111AbdH2LWd (ORCPT ); Tue, 29 Aug 2017 07:22:33 -0400 Received: from mout.web.de ([212.227.15.4]:50618 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096AbdH2LWb (ORCPT ); Tue, 29 Aug 2017 07:22:31 -0400 Subject: Re: [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure To: Daniel Lezcano Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, Florian Fainelli , Ray Jui , Scott Branden , Eric Anholt , Stefan Wahren , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com References: <20170829093354.GA2572@mai> <1503999271-15712-1-git-send-email-daniel.lezcano@linaro.org> <1503999271-15712-9-git-send-email-daniel.lezcano@linaro.org> From: SF Markus Elfring Message-ID: <1822c0d4-8f5d-611c-21df-4945f298be0a@users.sourceforge.net> Date: Tue, 29 Aug 2017 13:21:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1503999271-15712-9-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:7cgjsPgXFMKZAKqWoDUUf9V1lzVUOsHoZEP/9idRd36+8OdpwKq vPmVYprlcdFt4ZObkwECVg2lTbPQLlpU+kFSIxdTpCHRFiwrRpiVvM0RRV0joZcXEukGnFo +GdOGf3rglEWbdr976IaDCCoSO4GdBUKRWrrWEbXuG7BdZZRad7g4XogFVO7k1e7TRHPYtj OesmWOT+y5tYFWvPsXmYg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Rr11uCb8yNQ=:kP3yp5y5A2XH0fplAmcwKG s1JueUAJAkqMtnAHmIJcVD2in/AkEoQ/+ky9M+AbIHXpYsCUOIym/MN/oGjedY/q0xVAZ7Dur 4Tf9/WNB/5MRLryeR9mqsrLjTC7r9d5fiLrgiJ/ulA+08X+yt0aggL/OE3fXATrBONYeTWKPS cfJHOW94k3KDjxz0YRPNls0E4p1nD726vcZkXMbJtPDUnTdHbSEpfk1GbIRU4u3mZvizAZTtP bQuN5Nwnpsq2YWIJU+U+Xa0Dhjdwpyi76TnOdWv+zpg0mzFHOuqzrEK2FEst6mbWlOBcjvOOe +sJesP5S6CZNLwOviLgrVjOkKz7gqG0CZoVm2tnFjwbEN7EuazTMUcemP3tFG7YJwCFZlmnbx eaHoyFfbdqIiMYdkM1WC0cdIHAaSV6yDdL7NOUWB7iAG3ZzCTcwCbrXc0VVkVyZk9QMBwQb3x mpH5RPgLV/i0XfwlBDsviOPKMcw0l8qIntETMQCkSTCLDpEvmhEL7xez2uhnw/XMygTm9+r++ 7X8i92rmexsHTJNwM6YVFek+cslNWQ7y5L3ruI42Eraohx1j5xDyM+shcqU8JNvf+xL6SfTOe z+TD5nSf/35XimTi0eFLak5NFNCvJrJyBjKOeGk/5QfgYA8uQHZdr8PK+ac4XfMHuoB8LIPqI LWRjey2DTPKTYhnHWQaU3CWbJn+LP9dZHR2bIfQlzCiKCYIsPUmOpV2ImJMIPOKPwziGAQyta 2dSJijYXVjUyILYMwOp+nXb1u2SfxfbQuq5swqDPtN15h8l4oOLosGyBK5A5PXj4eIAfBmD6+ O8dskVTI2gDxv+abb/t+Cz9S5T9pUqTwaFp18MSryO+4eUXV+Q= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I would prefer to use the wording “for a” instead of “on” in the commit subject. > The bcm2835_timer_init() function emits an error message in case of a memory > allocation failure. This is pointless as the mm core already do that. Does this commit message contain a typo? Would a wording like “… does that already.” be more appropriate here? Regards, Markus