From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753224AbdLEOCF (ORCPT ); Tue, 5 Dec 2017 09:02:05 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:24890 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbdLEOCD (ORCPT ); Tue, 5 Dec 2017 09:02:03 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20171205140201epoutp021c3441d98dfbdff23029dc6ed7ace0f8~9atb0OHh90108201082epoutp02V X-AuditID: b6c32a38-ec5ff70000001183-68-5a26a6d94bb1 From: Bartlomiej Zolnierkiewicz To: Arvind Yadav Cc: tj@kernel.org, sergei.shtylyov@cogentembedded.com, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH] pata_pdc2027x: Fix coding sytle error Date: Tue, 05 Dec 2017 15:02:13 +0100 Message-id: <1823468.mnqCj3ft5Z@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <68e25992911d7c4d6c17b9f31524a614466d9588.1511605703.git.arvind.yadav.cs@gmail.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7bCmvu7NZWpRBjfms1lc613IbHFsxyMm i8u75rBZnFl1i93i1/KjjA6sHg+m/mfy2DnrLrvHplWdbB6fN8kFsERx2aSk5mSWpRbp2yVw ZSy7a1fwjbViYcs29gbG1yxdjJwcEgImEpcu7gOyuTiEBHYwSlz9tYwJwvnOKLFwx35mmKp5 x1ZBVW1glFg5awM7hPOVUeLKnrVsIFVsAlYSE9tXMYLYIgI6Eptm/gazmQUKJG41/2YFsYWB atZ2TQerZxFQlXg3azfYBl4BTYkHb5vAakQFvCS27GtnArE5BZIkmmYvYIOoEZT4MfkeC8RM eYl9+6eyQtg6EmePrWMEOUhCYAGbxIEVl5kgznaRePB+PRuELSzx6vgWoKs5gGxpiUtHbSHC 0xkltv+WgOjdzCixavcEdoiEtcTh4xehFvBJvPvawwrRyyvR0SYEYXpItDzOgqh2lNjxewMj JEyAxrRfvsY0gVF2FpKzZyE5exaSsxcwMq9iFEstKM5NTy02LDDRK07MLS7NS9dLzs/dxAhO AloWOxj3nPM5xCjAwajEwxswQy1KiDWxrLgy9xCjBAezkggvcz9QiDclsbIqtSg/vqg0J7X4 EKM0B4uSOK/o+msRQgLpiSWp2ampBalFMFkmDk6pBkbbH/P6dzm3ms3hXXnXNZ5/9s0Qu397 TqVKbX9TVPT44+pDdW+upM5gnmg6menehHOZDi/XuXo2+wiIBK/1FFzQn5ESsmh+tuhJt2Nb Zfc6B6VfTHhi8Fik20P14l4Bb4vVfF7FL1Sbbd+d/bzmyA3fzzXiHtVnracl73/9I/pWletK K+aKlbuUWIozEg21mIuKEwEGjvGj/gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsVy+t9jQd0by9SiDBZuVrO41ruQ2eLYjkdM Fpd3zWGzOLPqFrvFr+VHGR1YPR5M/c/ksXPWXXaPTas62Tw+b5ILYInisklJzcksSy3St0vg ylh2167gG2vFwpZt7A2Mr1m6GDk5JARMJOYdWwVkc3EICaxjlDgw8y0rhPOVUeLS1PusIFVs AlYSE9tXMYLYIgI6Eptm/gazmQUKJI5OmMoEYgsD1aztms4GYrMIqEq8m7WbGcTmFdCUePC2 CWyOqICXxJZ97WD1nAJJEt2/l7BBLNvKKDHj7Tk2iAZBiR+T77FALJCX2Ld/KiuErSWxfudx pgmM/LOQlM1CUjYLSdkCRuZVjJKpBcW56bnFRgWGeanlesWJucWleel6yfm5mxiBgbvtsFbf Dsb7S+IPMQpwMCrx8AbMUIsSYk0sK67MPcQowcGsJMLL3A8U4k1JrKxKLcqPLyrNSS0+xCjN waIkzns771ikkEB6YklqdmpqQWoRTJaJg1OqgVHI2C3tSNDSXkV9Abn2WbOvbpqd9mKe0Crr 2rjzv/r2/i/LabNwM+G+X8pdNKtKvsTh6vKuD+Vaf6YYrmefYbBdtmp/jcdrhpCarfJnvsmc Xlx8XsXefdHbJwy9ij8cbRv2PnM4XCUWKjeNfV5b4TOeAuZDy7dukGy+PXcv33ZFW8cKGZX/ KUosxRmJhlrMRcWJAN9AKHlYAgAA X-CMS-MailID: 20171205140200epcas1p384e56c48e11408e1729ab08ae0978039 X-Msg-Generator: CA CMS-TYPE: 101P X-CMS-RootMailID: 20171125103419epcas5p1e02e8409d9cb34cd3c592ca4e14961eb X-RootMTR: 20171125103419epcas5p1e02e8409d9cb34cd3c592ca4e14961eb References: <68e25992911d7c4d6c17b9f31524a614466d9588.1511605703.git.arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, November 25, 2017 04:04:07 PM Arvind Yadav wrote: > Fix these checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > ERROR: space prohibited after that '~' (ctx:WxW) > + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); > > ERROR: spaces required around that '?' (ctx:VxW) > + long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ; > > ERROR: that open brace { should be on the previous line > + const struct ata_port_info *ppi[] = > + { &pdc2027x_port_info[board_idx], NULL }; > > Signed-off-by: Arvind Yadav Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics