mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Joe Perches <joe@perches.com>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, apw@canonical.com,
	bp@alien8.de
Subject: Re: [PATCH] checkpatch.pl: Check for functions without a real prototype
Date: Mon, 18 Nov 2013 23:40:05 +0100	[thread overview]
Message-ID: <1823702.CebDozRkek@sandpuppy> (raw)
In-Reply-To: <1384814182.17783.5.camel@joe-AO722>

Am Montag, 18. November 2013, 14:36:22 schrieb Joe Perches:
> On Mon, 2013-11-18 at 23:31 +0100, Richard Weinberger wrote:
> > Functions like this one are evil:
> > 
> > void foo()
> > {
> > 
> > 	...
> > 
> > }
> > 
> > Signed-off-by: Richard Weinberger <richard@nod.at>
> > CC: hpa@zytor.com
> 
> I won't take simple resubmissions without updating
> based on the notes I gave you.

Of course. I managed it to send the *old* patch file.
Will resend in a minute...

> And now, this should be updated to allow --fix use too.
> 
> I'll take care of it instead.

Thanks,
//richard

  reply	other threads:[~2013-11-18 22:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 22:31 Richard Weinberger
2013-11-18 22:36 ` Joe Perches
2013-11-18 22:40   ` Richard Weinberger [this message]
2013-11-18 23:23     ` [PATCH] checkpatch.pl: Check for function declarations without arguments Joe Perches
2013-11-18 23:30       ` Borislav Petkov
  -- strict thread matches above, loose matches on Subject: below --
2012-03-16 21:22 [PATCH] x86: Merge x86_32 and x86_64 cpu_idle() H. Peter Anvin
2012-03-16 23:04 ` [PATCH] checkpatch.pl: Check for functions without a real prototype Richard Weinberger
2012-03-16 23:31   ` Joe Perches
2012-03-16 23:35     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1823702.CebDozRkek@sandpuppy \
    --to=richard@nod.at \
    --cc=apw@canonical.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®