From: Neil Brown <neilb@suse.de>
To: David Chinner <dgc@sgi.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: Regression - 2.6.24-rc3 - umem nvram card driver oops
Date: Tue, 4 Dec 2007 11:14:12 +1100 [thread overview]
Message-ID: <18260.39892.215075.795664@notabene.brown> (raw)
In-Reply-To: message from David Chinner on Tuesday December 4
On Tuesday December 4, dgc@sgi.com wrote:
> Neil,
>
> I just upgraded an ia64 (Altix, 16k page size) test box to 2.6.24-rc3
> from 2.6.23 and I get it panicing on boot in the umem driver.
Cool - someone is using umem! And even testing it. Thanks!
A quick look shows a probable NULL deref. Let me know if this fixes
it. I'll read through the offending patch more carefully and make
sure there is nothing else wrong.
NeilBrown
Fix possible NULL dereference in umem.c
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output
./drivers/block/umem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff .prev/drivers/block/umem.c ./drivers/block/umem.c
--- .prev/drivers/block/umem.c 2007-12-04 11:11:30.000000000 +1100
+++ ./drivers/block/umem.c 2007-12-04 11:11:42.000000000 +1100
@@ -484,7 +484,8 @@ static void process_page(unsigned long d
page->idx++;
if (page->idx >= bio->bi_vcnt) {
page->bio = bio->bi_next;
- page->idx = page->bio->bi_idx;
+ if (page->bio)
+ page->idx = page->bio->bi_idx;
}
pci_unmap_page(card->dev, desc->data_dma_handle,
next prev parent reply other threads:[~2007-12-04 0:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 21:35 David Chinner
2007-12-04 0:14 ` Neil Brown [this message]
2007-12-04 2:20 ` David Chinner
2007-12-04 2:48 ` Neil Brown
2007-12-04 9:37 ` Ingo Molnar
2007-12-16 21:15 ` [PATCH] umem nvram driver: clean up style Randy Dunlap
2007-12-16 21:55 ` Alexey Dobriyan
2007-12-17 0:49 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18260.39892.215075.795664@notabene.brown \
--to=neilb@suse.de \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®