From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79FEB30F924 for ; Tue, 27 Jan 2026 15:28:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527699; cv=none; b=W6z95lXRerV7NJu1pAeSN5P/C7zKSkhRYwi0s3VvDUs25wJoNfIndfTaCgvNBWc7wbUkzN77epBDuQ/SJLxer3dDVbuE03NAnM2MrQYU7dq70o5mZAM0Nh0hhJ1Gwrd3QxuFfSKKxMgC8PT7KNx55HZOKqA6QairAF7/Wf8tF1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527699; c=relaxed/simple; bh=eGHb2IDylVXxk4C2k9fPDOQuPDhvw+lJkydf+yTM1JM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bBiT+G3Gm+Fzwnhq0XzeYzJldeB8X8m6CyzPZdGs69xfaGnqatEAloXTg5nNJW4kJOgsWp/nBRA+3AMgLp7q97nXLau518HRN8LQM/6ETf2XrvOCcBLS9KMhLuj4nBG3WIpdOYwnbQC6JUSrnSCXp4QBikTq3h5z7vwNh2xYPVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=M6qI7ZZP; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="M6qI7ZZP" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 60R8n3Ga004217; Tue, 27 Jan 2026 15:28:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=/YgeQK ys5NwMIeOgNnR9Sxy1KEOuJJPzJ04pOCwerzM=; b=M6qI7ZZPtRKhtGg7CR9hzo GlJUIOX4sOOPr+6lupaN4jzTwKM03t5HLaVwLM+YsF14Gs2/AV70A5mYczIPtVnW gEheqgSh7tx/6VjhPWgXGiCBYRMpyl8ciBcHiU971mELkZuVu1iLHeZ4q9l7LhRJ FDmSUyNB/8n/0gVmT9kaC4bcYSYUYnKfZFGmIXc1WLSCANne+tWL/T3MTi737f0N bQ1BQgb9nvnCLx8q9Ap4zvtEL3VaxnkX/iRXnFP3fM1kquBXswgkFaulKT15rCRV +maBa1UOac0jSbQiFFfz3qw4DqGa5eFiBggj0FF+HgkZqmYvqrfzUCvhhh30vjHA == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4bvnt7p56g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:28:14 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 60RDKxVf019633; Tue, 27 Jan 2026 15:28:13 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4bw9dn160a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:28:13 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 60RFSC6T18285140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jan 2026 15:28:12 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7934858052; Tue, 27 Jan 2026 15:28:12 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5071458067; Tue, 27 Jan 2026 15:28:12 +0000 (GMT) Received: from [9.61.135.234] (unknown [9.61.135.234]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 27 Jan 2026 15:28:12 +0000 (GMT) Message-ID: <182650c0-4b4a-4a22-8ff6-a29838e8ee62@linux.ibm.com> Date: Tue, 27 Jan 2026 09:28:12 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/13] fsi: sbefifo: Convert to fsi bus probe mechanism To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <79dd5a9459f0719b7602165c89eb6fc24815f3b5.1765279318.git.u.kleine-koenig@baylibre.com> Content-Language: en-US From: Eddie James In-Reply-To: <79dd5a9459f0719b7602165c89eb6fc24815f3b5.1765279318.git.u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: gkhpZVfjqZHQpB0ql1DqjAo3K440pfKJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEyNSBTYWx0ZWRfX6/skPY5Fm7RY aydlPXaOmhIksOEPiwSzysy3pXLKp9YAfv7A5mpCUIMGpnYslX3RtYxhJ8iYa/Aw/C+Zybc5iKL NMFyoVFAUQUBBmSSCXYJJ4GBh693TMigXQeqNWvyYL6yQquhxqvHFpu9u0G3sxXrzS4/xO1/o+U BH9Q93kFHdQnUsKj2fEAMcBhNMP7W60aZpKMMS80yhg1x4kguw0uDhZJdrYpPalrHSvUi2cHnm/ yo+0HlgkftWHajitvGrrOc9BAC4ApAp3V1W71BpS2jORowR1y087HDV+Png86kmT391uR4urVvC 7fcM6B4ADCA5mx9m/FP5O5mvo/PND4arfoYXbTJwllWZT3Y3d6m8svyderWqQyFpk2YmyL4/Nin bkrbtotdl7JvizHMrgRbqoA6jCsb5HZVfhm9DJ0i+r4k8HpmFSyr1br6AQne3dryq4rWY7wefeQ SEMLn696yHJNUjlwx8A== X-Authority-Analysis: v=2.4 cv=Zs3g6t7G c=1 sm=1 tr=0 ts=6978d98e cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=IpJZQVW2AAAA:8 a=MWHlSUDAzK8B1r0af3AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-ORIG-GUID: gkhpZVfjqZHQpB0ql1DqjAo3K440pfKJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_03,2026-01-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2601150000 definitions=main-2601270125 On 12/9/25 5:40 AM, Uwe Kleine-König wrote: > The fsi bus got a dedicated probe function. Make use of that. This fixes > a runtime warning about the driver needing to be converted to the bus > probe method. Acked-by: Eddie James > > Signed-off-by: Uwe Kleine-König > --- > drivers/fsi/fsi-sbefifo.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c > index fde1c34743a0..6ca5817910cd 100644 > --- a/drivers/fsi/fsi-sbefifo.c > +++ b/drivers/fsi/fsi-sbefifo.c > @@ -1022,9 +1022,9 @@ static void sbefifo_free(struct device *dev) > * Probe/remove > */ > > -static int sbefifo_probe(struct device *dev) > +static int sbefifo_probe(struct fsi_device *fsi_dev) > { > - struct fsi_device *fsi_dev = to_fsi_dev(dev); > + struct device *dev = &fsi_dev->dev; > struct sbefifo *sbefifo; > struct device_node *np; > struct platform_device *child; > @@ -1045,7 +1045,7 @@ static int sbefifo_probe(struct device *dev) > > sbefifo->magic = SBEFIFO_MAGIC; > sbefifo->fsi_dev = fsi_dev; > - dev_set_drvdata(dev, sbefifo); > + fsi_set_drvdata(fsi_dev, sbefifo); > mutex_init(&sbefifo->lock); > sbefifo->timeout_in_cmd_ms = SBEFIFO_TIMEOUT_IN_CMD; > sbefifo->timeout_start_rsp_ms = SBEFIFO_TIMEOUT_START_RSP; > @@ -1101,9 +1101,10 @@ static int sbefifo_unregister_child(struct device *dev, void *data) > return 0; > } > > -static int sbefifo_remove(struct device *dev) > +static void sbefifo_remove(struct fsi_device *fsi_dev) > { > - struct sbefifo *sbefifo = dev_get_drvdata(dev); > + struct device *dev = &fsi_dev->dev; > + struct sbefifo *sbefifo = fsi_get_drvdata(fsi_dev); > > dev_dbg(dev, "Removing sbefifo device...\n"); > > @@ -1117,8 +1118,6 @@ static int sbefifo_remove(struct device *dev) > fsi_free_minor(sbefifo->dev.devt); > device_for_each_child(dev, NULL, sbefifo_unregister_child); > put_device(&sbefifo->dev); > - > - return 0; > } > > static const struct fsi_device_id sbefifo_ids[] = { > @@ -1131,10 +1130,10 @@ static const struct fsi_device_id sbefifo_ids[] = { > > static struct fsi_driver sbefifo_drv = { > .id_table = sbefifo_ids, > + .probe = sbefifo_probe, > + .remove = sbefifo_remove, > .drv = { > .name = DEVICE_NAME, > - .probe = sbefifo_probe, > - .remove = sbefifo_remove, > } > }; >