From: Joe Perches <joe@perches.com>
To: Binyi Han <dantengknight@gmail.com>,
Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Coiby Xu <coiby.xu@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: qlge: Fix indentation issue under long for loop
Date: Sat, 09 Jul 2022 19:23:20 -0700 [thread overview]
Message-ID: <1827050fdadb6173118fb396ad1fead23cda809f.camel@perches.com> (raw)
In-Reply-To: <20220710021629.GA11852@cloud-MacBookPro>
On Sat, 2022-07-09 at 19:16 -0700, Binyi Han wrote:
> Fix indentation issue to adhere to Linux kernel coding style.
> Issue found by checkpatch.
>
> Signed-off-by: Binyi Han <dantengknight@gmail.com>
> ---
> drivers/staging/qlge/qlge_main.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
[]
> @@ -3009,8 +3009,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
>
> for (page_entries = 0; page_entries <
> MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
Probably better to change the for loop to 3 lines as well.
for (page_entries = 0;
page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
page_entries++)
> @@ -3024,8 +3024,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
>
> for (page_entries = 0; page_entries <
> MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> - base_indirect_ptr[page_entries] =
> - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> + base_indirect_ptr[page_entries] =
> + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
etc...
next prev parent reply other threads:[~2022-07-10 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 2:16 Binyi Han
2022-07-10 2:23 ` Joe Perches [this message]
2022-07-10 8:27 ` binyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1827050fdadb6173118fb396ad1fead23cda809f.camel@perches.com \
--to=joe@perches.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=dantengknight@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®