mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@it.uu.se>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: Mikael Pettersson <mikpe@it.uu.se>,
	lenb@kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: acpi ->video_device_list corruption
Date: Wed, 12 Dec 2007 13:12:57 +0100	[thread overview]
Message-ID: <18271.53321.104822.233365@harpo.it.uu.se> (raw)
In-Reply-To: <20071212115655.GB18472@holomorphy.com>

William Lee Irwin III writes:
 > On Wed, Dec 12, 2007 at 12:48:09PM +0100, Mikael Pettersson wrote:
 > > IMO the memset(ptr, 0, sizeof(*ptr)) idiom is both safer
 > > and avoids having to write an uninteresting type name.
 > 
 > How about this, then?

Looks good.

Acked-by: Mikael Pettersson <mikpe@it.uu.se>

 > 
 > The ->cap fields of struct acpi_video_device and struct acpi_video_bus
 > are 1B each, not 4B. The oversized memset()'s corrupted the subsequent
 > list_head fields. This resulted in silent corruption without
 > CONFIG_DEBUG_LIST and BUG's with it. This patch uses sizeof() to pass
 > the proper bounds to the memset() calls and thereby correct the bugs.
 > 
 > The patch was seen to resolve the issue on the affected system.
 > 
 > vs. 2.6.24-rc5
 > 
 > Signed-off-by: William Irwin <wli@holomorphy.com>
 > 
 > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
 > index 44a0d9b..bd77e81 100644
 > --- a/drivers/acpi/video.c
 > +++ b/drivers/acpi/video.c
 > @@ -577,7 +577,7 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device)
 >  	struct acpi_video_device_brightness *br = NULL;
 >  
 >  
 > -	memset(&device->cap, 0, 4);
 > +	memset(&device->cap, 0, sizeof(device->cap));
 >  
 >  	if (ACPI_SUCCESS(acpi_get_handle(device->dev->handle, "_ADR", &h_dummy1))) {
 >  		device->cap._ADR = 1;
 > @@ -697,7 +697,7 @@ static void acpi_video_bus_find_cap(struct acpi_video_bus *video)
 >  {
 >  	acpi_handle h_dummy1;
 >  
 > -	memset(&video->cap, 0, 4);
 > +	memset(&video->cap, 0, sizeof(video->cap));
 >  	if (ACPI_SUCCESS(acpi_get_handle(video->device->handle, "_DOS", &h_dummy1))) {
 >  		video->cap._DOS = 1;
 >  	}
 > --
 > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
 > the body of a message to majordomo@vger.kernel.org
 > More majordomo info at  http://vger.kernel.org/majordomo-info.html
 > Please read the FAQ at  http://www.tux.org/lkml/
 > 

  reply	other threads:[~2007-12-12 12:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-12 10:15 William Lee Irwin III
2007-12-12 11:48 ` Mikael Pettersson
2007-12-12 11:56   ` William Lee Irwin III
2007-12-12 12:12     ` Mikael Pettersson [this message]
2007-12-13 21:24       ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18271.53321.104822.233365@harpo.it.uu.se \
    --to=mikpe@it.uu.se \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®