From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932251AbbKYJDo (ORCPT ); Wed, 25 Nov 2015 04:03:44 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:58606 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754767AbbKYJDg (ORCPT ); Wed, 25 Nov 2015 04:03:36 -0500 From: Arnd Bergmann To: Stephen Boyd Cc: Daniel Lezcano , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andy Gross Subject: Re: [PATCH 1/3] clocksource: defbool CLKSRC_QCOM=y on ARCH_QCOM and make it visible Date: Wed, 25 Nov 2015 10:03:02 +0100 Message-ID: <18283780.80p4aZiYqH@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <565517D8.5000705@codeaurora.org> References: <1448413710-8101-1-git-send-email-sboyd@codeaurora.org> <1448413710-8101-2-git-send-email-sboyd@codeaurora.org> <565517D8.5000705@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:3rfxXyOx1UGtPGYsh2Klo1R0GhG7NdJlJTV5Jmsne2q09bTF824 8sVqTAbvE34o8yP4ZvAlfd66mufiNhspOj9NXvGh9old+asIK/6nvitbggqPiiEjh1PQAen Ni2mcguPTjTSwdooVb86L4r1DnP8VaE76euNCfSgedPVZV5U/ewCswpclO2hjH+X/n/V40l jfEoqw2HOVFgEQdYSd6bQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:dTUnxaJB0lo=:Gz1xyzEcR0Dw+bwglcKOCX 8BiYocsCRAZO7SFaK1eSO8tDWTMC2QqxnEoaM0P2OlgbJCNpzs/4dEnwOBM7+W+fzLqj25XDU T7MZ+rN/r6OfQwRBkJDLFmoZGQDyciAZjL7ar4vgeqRY915dIPL8JmHtvDpEG2M0O0MOPwURq A57Q7CnHzT5auZr0NXQdXTd9CxMOHEGUvXBXj9p1vp1H2drYOo76EOysyXn1ExInHsun3f1kA s9OAov5jd6wRgvWjUKIXDK657Gfon53dqXuhEeJBwbtAECqb+4P9vZJUN6qJfkpc20/2YQuIa 7kWd8hFGvhPvO2USi7sOkLF72n8ubU8TbJw0U8+LbJeI6oiRsewzUBaG3j2bOtRwqSqlOYTV/ H+m3r/4rfWBcH4sIOppZ2FjhzuotyWAvkKemPwFBFcrowLSlqgcKEuF2qEgCwjR9ZY8Tovkxg zcdNMjgQQjJz2BZnF2wmAMuOQqtTzTscUEB9E+RyX0MDVk+52BE21Me2n9aGh2lhzWY3EWMNy 5NuPcZOBF+0+XPsk8ZLZt3BrfifxsMb94Xun8BxGqAOtRHHFmhT+PtYwHWxT+A7BvB15LkdK4 5XmY8zWJbwFzB+IN4MSFpfoQ2LH0kUVYUAGmpvBdFOSNcaFZS2gC3LtzJC586OvuFgYt+deWo WmHHain2bTbOdTNVDS7zlGnDQQwKK2+Eph8KU4JxtkAqK9SRGIpoTbCcQP7NmKJZbMm9mXC1x NvHfol/DQaiJRAHd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 24 November 2015 18:07:20 Stephen Boyd wrote: > On 11/24/15 17:08, Stephen Boyd wrote: > > We want to remove the ARCH_MSM* configs in mach-qcom/Kconfig > > because they are mostly proxy configs for selecting the right > > clocksource driver. Therefore, make CLKSRC_QCOM default to the > > value of ARCH_QCOM, but also make it visible if ARCH_QCOM=y so > > that we can turn it off when we don't want it. > > > > Suggested-by: Arnd Bergmann > > Signed-off-by: Stephen Boyd > > --- > > drivers/clocksource/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > index b423785d6afc..7a5ffaa3e490 100644 > > --- a/drivers/clocksource/Kconfig > > +++ b/drivers/clocksource/Kconfig > > @@ -279,9 +279,10 @@ config EM_TIMER_STI > > such as EMEV2 from former NEC Electronics. > > > > config CLKSRC_QCOM > > - bool "Qualcomm MSM timer" if COMPILE_TEST > > + bool "Qualcomm MSM timer" if ARCH_QCOM || COMPILE_TEST > > depends on ARM > > select CLKSRC_OF > > + defbool ARCH_QCOM > > Urgh. This should be def_bool > > With this fixed, the series looks good to me. If Daniel can Ack this, I'd suggest we take the series through arm-soc. Arnd