From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D88E228C009 for ; Tue, 31 Mar 2026 03:55:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.119 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774929317; cv=none; b=i75UrvSJEjeJAIBBK5QT19/Z/XrzHXxp5/cu4utZYAvm+k3herxKazQMOmvKqOqdfSaLpc6V0pmj83zXO26eJU9XHlG24SWnBW5CSzE6bF80mSt5d1zw8xDgrk2qZbOiluO08h+Boc2IOZBNajuWAU3c68hp2DJz5jepI15sJbs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774929317; c=relaxed/simple; bh=yyExDjTZDloPBwOS8ok33+57AMAiA47V3dotZLDY38o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tW47MW0p16G+oX5v+GRMSvuZ8aGHcAzTw1B/T8mNSwUmvgE9bKTtybBeOvH5BZ1Dkl4AcQPWipWViNygLfHD2/80EFEa+fWEjfCWcU/ornAJo89dvZDc0rz1bEpvoWJlH17htprFJ0MEN/bsHjPjifb0ZwXl5vRbIPH4EfuWx0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=UV9eaiU3; arc=none smtp.client-ip=115.124.30.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="UV9eaiU3" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1774929305; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=90nLfsMsqKPNUBQhqb1+gfAb9vhKGrTCZbMIRgMjGTI=; b=UV9eaiU3UGQp8OWBH2oNek3G2j0/V6RtdlVDSahSekDwlp7kATasrYKxv5BrkvlDNE1fNOFRdsJi0/aUVXOpjBCc9Y6y+5Y4XBwMU7t8jcdX/wMR4V54htrku7Po36cjy3OaMsMdRMy05v/0VEw4nZ7Eyw6MdyYUp+bgtyBlmEw= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam011083073210;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0X02vttY_1774929304; Received: from 30.221.131.145(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0X02vttY_1774929304 cluster:ay36) by smtp.aliyun-inc.com; Tue, 31 Mar 2026 11:55:05 +0800 Message-ID: <1828ed19-e9d0-4908-926a-0e0a9c3d04af@linux.alibaba.com> Date: Tue, 31 Mar 2026 11:55:03 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [PATCH v2] erofs: fix missing folio_unlock causing lock imbalance To: Zhan Xusheng , Gao Xiang Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Zhan Xusheng References: <20260331033300.21366-1-zhanxusheng@xiaomi.com> <20260331034631.21945-1-zhanxusheng@xiaomi.com> From: Gao Xiang In-Reply-To: <20260331034631.21945-1-zhanxusheng@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026/3/31 11:46, Zhan Xusheng wrote: > folio_trylock() in erofs_try_to_free_all_cached_folios() may > successfully acquire the folio lock, but the subsequent check > for erofs_folio_is_managed() can skip unlocking when the folio > is not managed by EROFS. > > As Gao Xiang pointed out, this condition should not happen in > practice because compressed_bvecs[] only holds valid cached folios > at this point — any non-managed folio would have already been > detached by z_erofs_cache_release_folio() under folio lock. > > Fix this by adding DBG_BUGON() to catch unexpected folios > and ensure folio_unlock() is always called. > > Suggested-by: Gao Xiang > Signed-off-by: Zhan Xusheng emmm, the patch subject needs to be changed too, like: [PATCH v3] erofs: ensure all folios are managed in erofs_try_to_free_all_cached_folios() Thanks, Gao Xiang > --- > fs/erofs/zdata.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c > index fe8121df9ef2..b566996a0d1a 100644 > --- a/fs/erofs/zdata.c > +++ b/fs/erofs/zdata.c > @@ -605,8 +605,7 @@ static int erofs_try_to_free_all_cached_folios(struct erofs_sb_info *sbi, > if (!folio_trylock(folio)) > return -EBUSY; > > - if (!erofs_folio_is_managed(sbi, folio)) > - continue; > + DBG_BUGON(!erofs_folio_is_managed(sbi, folio)); > pcl->compressed_bvecs[i].page = NULL; > folio_detach_private(folio); > folio_unlock(folio);