From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751590Ab3HTOGQ (ORCPT ); Tue, 20 Aug 2013 10:06:16 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:49349 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751345Ab3HTOGN (ORCPT ); Tue, 20 Aug 2013 10:06:13 -0400 From: "Rafael J. Wysocki" To: Mika Westerberg Cc: linux-i2c@vger.kernel.org, Wolfram Sang , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Lv Zheng , Aaron Lu Subject: Re: [RFC PATCH 2/2] i2c: attach/detach I2C client device to the ACPI power domain Date: Tue, 20 Aug 2013 16:16:46 +0200 Message-ID: <1832329.klZ26Zknis@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.11.0-rc5+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <1377007416-13851-3-git-send-email-mika.westerberg@linux.intel.com> References: <1377007416-13851-1-git-send-email-mika.westerberg@linux.intel.com> <1377007416-13851-3-git-send-email-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, August 20, 2013 05:03:36 PM Mika Westerberg wrote: > From: Lv Zheng > > If the I2C client device is enumerated from ACPI namespace it might have > ACPI methods that needs to be called in order to transition the device to > a different power states (such as _PSx). > > Implement this for I2C client devices by checking if the device has an ACPI > handle and if that's the case, attach it to the ACPI power domain. In > addition we make sure that the device is fully powered when its ->probe() > function gets called. > > For non-ACPI devices this patch is a no-op. > > Signed-off-by: Lv Zheng > Signed-off-by: Mika Westerberg Acked-by: Rafael J. Wysocki > --- > drivers/i2c/i2c-core.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > index 8fad5ac..fdf086b 100644 > --- a/drivers/i2c/i2c-core.c > +++ b/drivers/i2c/i2c-core.c > @@ -257,6 +257,9 @@ static int i2c_device_probe(struct device *dev) > /* Make sure the adapter is active */ > pm_runtime_get_sync(&client->adapter->dev); > > + if (ACPI_HANDLE(&client->dev)) > + acpi_dev_pm_attach(&client->dev, true); > + > /* > * Enable runtime PM for the client device. If the client wants to > * participate on runtime PM it should call pm_runtime_put() in its > @@ -278,6 +281,9 @@ static int i2c_device_probe(struct device *dev) > pm_runtime_disable(&client->dev); > pm_runtime_set_suspended(&client->dev); > pm_runtime_put_noidle(&client->dev); > + > + if (ACPI_HANDLE(&client->dev)) > + acpi_dev_pm_detach(&client->dev, true); > } > > pm_runtime_put(&client->adapter->dev); > @@ -314,6 +320,9 @@ static int i2c_device_remove(struct device *dev) > pm_runtime_set_suspended(&client->dev); > pm_runtime_put_noidle(&client->dev); > > + if (ACPI_HANDLE(&client->dev)) > + acpi_dev_pm_detach(&client->dev, true); > + > pm_runtime_put(&client->adapter->dev); > return status; > } > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.