Re: [PATCH net-next] tipc: Replace msecs_to_jiffies() with secs_to_jiffies()

[Thorsten Blum <thorsten.blum@linux.dev>]

On 28. Apr 2025, at 04:31, Tung Quang Nguyen wrote:
>> Use secs_to_jiffies() instead of msecs_to_jiffies() and avoid scaling 'delay' to
>> milliseconds in tipc_crypto_rekeying_sched(). Compared to msecs_to_jiffies(),
>> secs_to_jiffies() expands to simpler code and reduces the size of 'tipc.ko'.
> I observed an opposite result after applying your patch, an increasement of 320 bytes.
> Before patch:
> 969392 Apr 28 08:53 tipc.ko
> 
> After patch:
> 969712 Apr 28 09:11 tipc.ko

Which architecture and config did you use?

For x86_64 using LLVM, defconfig, and CONFIG_TIPC=m I get 929960 bytes
before and 929864 bytes after my patch, so 96 bytes less than before.

For arm64 using LLVM, defconfig, and CONFIG_TIPC=m, I get 8005616 bytes
before and 8005304 bytes after my patch, so 312 bytes less than before.

Thanks,
Thorsten