From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753821AbcHWPf3 (ORCPT ); Tue, 23 Aug 2016 11:35:29 -0400 Received: from gloria.sntech.de ([95.129.55.99]:35872 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753507AbcHWPfD (ORCPT ); Tue, 23 Aug 2016 11:35:03 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sudip Mukherjee Cc: Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] crypto: rockchip - use devm_add_action_or_reset() Date: Tue, 23 Aug 2016 17:34:43 +0200 Message-ID: <1832912.bMZSrNDq9I@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: <1471964334-27060-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1471964334-27060-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 23. August 2016, 20:28:54 schrieb Sudip Mukherjee: > If devm_add_action() fails we are explicitly calling the cleanup to free > the resources allocated. Lets use the helper devm_add_action_or_reset() > and return directly in case of error, as we know that the cleanup function > has been already called by the helper if there was any error. > > Signed-off-by: Sudip Mukherjee nice little cleanup Reviewed-by: Heiko Stuebner