From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755972AbYAZT4V (ORCPT ); Sat, 26 Jan 2008 14:56:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753262AbYAZT4G (ORCPT ); Sat, 26 Jan 2008 14:56:06 -0500 Received: from aun.it.uu.se ([130.238.12.36]:54402 "EHLO aun.it.uu.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbYAZT4E (ORCPT ); Sat, 26 Jan 2008 14:56:04 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18331.36943.555996.210681@harpo.it.uu.se> Date: Sat, 26 Jan 2008 20:55:59 +0100 From: Mikael Pettersson To: Sam Ravnborg Cc: Mikael Pettersson , matthew@wil.cx, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 2.6.24] sym53c8xx_2 modpost section mismatch fix In-Reply-To: <20080126181205.GA25319@uranus.ravnborg.org> References: <200801261803.m0QI3Fen025895@harpo.it.uu.se> <20080126181205.GA25319@uranus.ravnborg.org> X-Mailer: VM 7.17 under Emacs 20.7.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sam Ravnborg writes: > On Sat, Jan 26, 2008 at 07:03:15PM +0100, Mikael Pettersson wrote: > > Building 2.6.24 with > > > > # CONFIG_HOTPLUG is not set > > CONFIG_SCSI_SYM53C8XX_2=y > > > > results in the following during modpost: > > > > WARNING: vmlinux.o(.text+0x14b36c): Section mismatch: reference to .exit.text:sym2_remove (between 'sym2_io_error_detected' and 'sym_set_cam_result_error') > > > > because sym2_io_error_detected() calls sym2_remove(), which is marked __devexit. > > > > Fixed by removing the __devexit from sym2_remove(). > > > > Signed-off-by: Mikael Pettersson > > --- > > Resend. Previously reported against 2.6.24-rc6 on 2007-12-15. > > Fixed in upstream kernel by > commit: 864473bbbbcbe99e95a57ad496894768cd77a567 Great, thanks.