From: Paul Mackerras <paulus@samba.org>
To: balbir@linux.vnet.ibm.com
Cc: Michael Ellerman <michael@ellerman.id.au>,
linuxppc-dev@ozlabs.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fake NUMA emulation for PowerPC (Take 2)
Date: Sun, 27 Jan 2008 22:55:43 +1100 [thread overview]
Message-ID: <18332.28991.658933.763115@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20080126071339.GA25328@balbir.in.ibm.com>
Balbir Singh writes:
> Here's a better and more complete fix for the problem. Could you
> please see if it works for you? I tested it on a real NUMA box and it
> seemed to work fine there.
There are a couple of other changes in behaviour that your patch
introduces, and I'd like to understand them better before taking the
patch. First, with your patch we don't set nodes online if they end
up having no memory in them because of the memory limit, whereas
previously we did. Secondly, in the case where we don't have NUMA
information, we now set node 0 online after adding each LMB, whereas
previously we only set it online once.
If in fact these changes are benign, then your patch description
should mention them and explain why they are benign.
Paul.
next prev parent reply other threads:[~2008-01-27 11:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 22:37 Balbir Singh
2007-12-10 19:36 ` Balbir Singh
2007-12-10 23:07 ` Olof Johansson
2008-01-18 5:34 ` Michael Ellerman
2008-01-18 5:41 ` Balbir Singh
2008-01-18 5:44 ` Michael Ellerman
2008-01-18 7:08 ` Balbir Singh
2008-01-26 7:13 ` Balbir Singh
2008-01-27 11:55 ` Paul Mackerras [this message]
2008-01-27 15:01 ` Balbir Singh
2008-01-27 20:22 ` Nish Aravamudan
2008-01-28 9:41 ` Balbir Singh
2008-01-28 12:52 ` [PATCH powerpc] Fake NUMA emulation for PowerPC (Take 3) Balbir Singh
2008-01-29 13:04 ` Michael Ellerman
2008-01-29 13:50 ` Balbir Singh
2008-02-01 4:57 ` [PATCH powerpc] Fake NUMA emulation for PowerPC (Take 4) Balbir Singh
2008-01-18 5:55 ` [PATCH] Fake NUMA emulation for PowerPC (Take 2) Michael Ellerman
2008-01-18 6:51 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18332.28991.658933.763115@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®