From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7E18C04A94 for ; Mon, 14 Aug 2023 08:50:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233946AbjHNItz (ORCPT ); Mon, 14 Aug 2023 04:49:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235014AbjHNItc (ORCPT ); Mon, 14 Aug 2023 04:49:32 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EACB41996; Mon, 14 Aug 2023 01:49:08 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 42ED85C0113; Mon, 14 Aug 2023 04:48:58 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 14 Aug 2023 04:48:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1692002938; x=1692089338; bh=+3 8f974ozKkBT9tcgLskyLKWI6WqBjgFXMu9A+bbIEo=; b=B22MYGgwXdnEmy8M2d zWLg6JuwwXV2G2YCaDTI7uKoerGnU+ZxNpSwWdlycgF/6eoXy2EqWXKldGCVBTzw 0YhpXs914ahvndhEQKzLCA9StBhITBc8f2MlP6t1fnaxMppSHapgepaoze26bKIu EgRcxzcVM3gpsx5ZMCcdCFk/jOE38kYXzpNPOu+Z1Sfab1IhXiSDy4rtf1qIdNor VfsHox8IszRpqKd/2DjKeQYx9cLGqfknt2V9PgKtp4hW0ApuQPc9wQ+LD9kt6X/P TtemuXAF+2Cv6oIw/a/J5fpNpSmiY5Y05YK1hXIQHZRsW/h2R3ihVP/1UpM/gKXh NUhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1692002938; x=1692089338; bh=+38f974ozKkBT 9tcgLskyLKWI6WqBjgFXMu9A+bbIEo=; b=FMMKiKQ3eTY8Exyaqh5kjBDFVCvc3 4kyc/RmzH4rIYlAUAD4AtkPpebSrQA4smGzrRDpJNJ5XycLp/cNRFwFrPf5sDQ4T YiUWvwYxyjQpcECQDbD9jRjMGCdyMYLSZ6TDO82RRkNpl4e6fVO3tb0e3GZYjnca rKHi7rCqAFnJ1BuD2P4kgk+eAa9/RwGn/zD37oQ/TcEzqjK8uhw6lTPRk2eNa1i1 Z+LB7FdbIYMhj9ual7ct/O3KovznklwIW2PwmFEI8eIiASnlsWV8QNlfMXQMDb7S kTCsZ3Kn2lXYD+ip+OwEuMeZstUVEmqLwsKXFXVapMLCrC5Ex7llty0dQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddtgedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B01E4B60089; Mon, 14 Aug 2023 04:48:57 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440 Mime-Version: 1.0 Message-Id: <1834eee9-3fbd-4bea-9e22-960ca993303c@app.fastmail.com> In-Reply-To: References: <20230814073924.1066390-1-arnd@kernel.org> Date: Mon, 14 Aug 2023 10:48:37 +0200 From: "Arnd Bergmann" To: "xingtong.wu" , "Arnd Bergmann" , "Wim Van Sebroeck" , "Guenter Roeck" , "Hans de Goede" Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, "Haeussler, Gerd" , "Schaffner, Tobias" , "xingtong.wu" Subject: Re: [PATCH] watchdog: simatic: add PCI dependency Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14, 2023, at 10:27, xingtong.wu wrote: >> >> config SIEMENS_SIMATIC_IPC_WDT >> tristate "Siemens Simatic IPC Watchdog" >> - depends on SIEMENS_SIMATIC_IPC >> + depends on SIEMENS_SIMATIC_IPC && PCI > > The SIEMENS_SIMATIC_IPC_WDT does not depends on PCI directly, > it should depends on P2SB, then P2SB depends on PCI > >> default y >> select WATCHDOG_CORE >> select P2SB > > You can replace the "select" to "depends on" instead. That would also work, but it's generally best not to mix 'depends on' and 'select' for the same symbol. Changing all three 'select P2SB' to 'depends on P2SB', or removing the prompt to turn P2SB itself into a hidden symbol is probably a good follow-up patch, but I'd keep that separate from the regression fix. Arnd