From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
zam@namesys.com, linux-kernel@vger.kernel.org,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH try #2] fuse: fix error case in fuse_readpages
Date: Fri, 11 Aug 2006 09:11:47 +0100 [thread overview]
Message-ID: <18358.1155283907@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060810125306.61425f94.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> wrote:
> > Don't let fuse_readpages leave the @pages list not empty when exiting
> > on error.
> >
>
> Oh dear. read_cache_pages_release_page() is not a readahead thing. It is
> a dhowells fscache thing.
The pages passed to read_cache_pages() may already be marked with metadata
information (such as to-be-cached marks from NFS or AFS calling FS-Cache), so
we can't just ditch the pages on an error, we have to clean them up properly.
David
prev parent reply other threads:[~2006-08-11 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 9:28 Miklos Szeredi
2006-08-10 19:53 ` Andrew Morton
2006-08-11 8:11 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18358.1155283907@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=zam@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®