From: Neil Brown <neilb@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Adrian Bunk <bunk@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fs/drop_caches.c: make 2 functions static
Date: Tue, 19 Feb 2008 08:45:03 +1100 [thread overview]
Message-ID: <18361.64607.812442.423082@notabene.brown> (raw)
In-Reply-To: message from Andrew Morton on Monday February 18
On Monday February 18, akpm@linux-foundation.org wrote:
> On Sun, 17 Feb 2008 10:17:46 +0200 Adrian Bunk <bunk@kernel.org> wrote:
>
> > This patch makes the following needlessly global functions static:
> > - drop_pagecache()
> > - drop_slab()
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
..
>
> This was originally done because Neil said that he planned to use these in
> nfsd. I guess that didn't happen, and an additional patch would be needed
> here anyway to do the module exports. So.... zap.
Did I? I wonder why. Neither my memory or my mail archive gives me
any hints, so I suspect it must have just been a passing fancy that
resolved into a really dumb idea (as so many passing fancies do).
Zap-supported-by: NeilBrown <neilb@suse.de>
Hmmm... I guess that should really be
Acked-By: NeilBrown <neilb@suse.de>
;-)
NeilBrown
prev parent reply other threads:[~2008-02-18 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 8:17 Adrian Bunk
2008-02-18 13:01 ` Andrew Morton
2008-02-18 21:45 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18361.64607.812442.423082@notabene.brown \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®