From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933126AbdKACOb (ORCPT ); Tue, 31 Oct 2017 22:14:31 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:9984 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932667AbdKACOa (ORCPT ); Tue, 31 Oct 2017 22:14:30 -0400 Subject: Re: [PATCH] f2fs: don't bother with inode->i_version To: Jeff Layton , CC: , , References: <20171030151156.6418-1-jlayton@kernel.org> From: Chao Yu Message-ID: <1836bd00-d64e-feb5-4033-8ffd5934f47f@huawei.com> Date: Wed, 1 Nov 2017 10:14:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171030151156.6418-1-jlayton@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0205.59F92DF4.0089,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 071c1021f301dc2adf27d46c210dd0a6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/10/30 23:11, Jeff Layton wrote: > From: Jeff Layton > > f2fs does not set the SB_I_VERSION flag, so the i_version will never > be incremented on write. It was recently changed to increment the > i_version on a quota write, which isn't necessary here. > > Signed-off-by: Jeff Layton Reviewed-by: Chao Yu Thanks, > --- > fs/f2fs/super.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 933c3d529e65..b3359158e7be 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -618,7 +618,6 @@ static struct inode *f2fs_alloc_inode(struct super_block *sb) > init_once((void *) fi); > > /* Initialize f2fs-specific inode info */ > - fi->vfs_inode.i_version = 1; > atomic_set(&fi->dirty_pages, 0); > fi->i_current_depth = 1; > fi->i_advise = 0; > @@ -1386,7 +1385,6 @@ static ssize_t f2fs_quota_write(struct super_block *sb, int type, > > if (len == towrite) > return 0; > - inode->i_version++; > inode->i_mtime = inode->i_ctime = current_time(inode); > f2fs_mark_inode_dirty_sync(inode, false); > return len - towrite; >