From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754707AbbGYKOb (ORCPT ); Sat, 25 Jul 2015 06:14:31 -0400 Received: from mail.eperm.de ([89.247.134.16]:48009 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752458AbbGYKOa (ORCPT ); Sat, 25 Jul 2015 06:14:30 -0400 From: Stephan Mueller To: Kees Cook Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: Re: [PATCH] jent: use safe format string parameters Date: Sat, 25 Jul 2015 12:14:27 +0200 Message-ID: <1837679.rRPrBYE39B@tauon.atsec.com> User-Agent: KMail/4.14.9 (Linux/4.0.7-300.fc22.x86_64; KDE/4.14.9; x86_64; ; ) In-Reply-To: <20150724224127.GA29924@www.outflux.net> References: <20150724224127.GA29924@www.outflux.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 24. Juli 2015, 15:41:27 schrieb Kees Cook: Hi Kees, >Since the API for jent_panic() does not include format string parameters, >adjust the call to panic() to use a literal string to avoid any future >callers from leaking format strings into the panic message. > >Signed-off-by: Kees Cook Thanks. Acked-by: Stephan Mueller >--- > crypto/jitterentropy-kcapi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/crypto/jitterentropy-kcapi.c b/crypto/jitterentropy-kcapi.c >index b32d834144cd..ceea83d13168 100644 >--- a/crypto/jitterentropy-kcapi.c >+++ b/crypto/jitterentropy-kcapi.c >@@ -79,7 +79,7 @@ int jent_fips_enabled(void) > > void jent_panic(char *s) > { >- panic(s); >+ panic("%s", s); > } > > void jent_memcpy(void *dest, const void *src, unsigned int n) Ciao Stephan