From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751403Ab1BMF3M (ORCPT ); Sun, 13 Feb 2011 00:29:12 -0500 Received: from mail-pv0-f174.google.com ([74.125.83.174]:37499 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783Ab1BMF3E (ORCPT ); Sun, 13 Feb 2011 00:29:04 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=oHP1fmGIJgTHC4b624W/g7ZKNJKL8Wf7cLw+T9RkBpsGDeU7iY7XFGGb0PVwzKGVQZ ZwwjoSKoizNkKRs1IxX/VNIBn1KgzHU5Y+y8dvEjdOQh5scRCMHxJF8h+/Xkx1wLvAxq qnueFGMeSAkELXjQAq0bVbL3xmIxAtGyzdOI0= Cc: dri-devel@lists.freedesktop.org, "linux-kernel@vger.kernel.org" , airlied@redhat.com Message-Id: <1838D776-BF70-4ABE-98CB-EFDCF828F6CF@gmail.com> From: Justin Mattock To: Alex Deucher In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: [BISECTED] commit 619efb1059 makes the MacBookPro2,2 screen flicker like its broken or half plugged in Date: Sat, 12 Feb 2011 21:28:58 -0800 References: <4D51AD03.7030401@gmail.com> X-Mailer: Apple Mail (2.936) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Feb 11, 2011, at 5:15 PM, Alex Deucher wrote: > On Fri, Feb 11, 2011 at 10:57 AM, Justin Mattock > wrote: >> >>> >>> Better yet, can you try the attached patch on top of 2.6.38-rc4 or >>> newer? >>> >>> Alex >>> >> >> o.k. applied that patch... unfortunately Im seeing the flickering >> screen and >> the crud shows up.. >> initially during boot everything looked fine, its when I suspended >> the >> machine, upon wake-up >> the flickering occurred. >> kernel version is the current: 2.6.38-rc4-00107-gaa502b4 > > Can you try this patch? Try uncommenting the following lines to see > if either of those flags work any better. Try them individually and > together if possible and report back which, if any, helps. > > /*pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;*/ > > /*if (ASIC_IS_AVIVO(rdev)) > pll->flags |= RADEON_PLL_USE_FRAC_FB_DIV;*/ > > Thanks! > > Alex > >> >> Justin P. Mattock >> > <0001-drm-radeon-kms-hopefully-fix-pll-issues-for-real-v2.patch> alright.. again out of my office trying to make a living!! Anyways I applied the two earlier patches, and added the previous post's patch as well (everything runs o.k. s2r etc...) I can try for the above and see if I can pinpoint the piece of code that is causing this(hopefully) Justin P. Mattock