From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753005AbdBTMxS (ORCPT ); Mon, 20 Feb 2017 07:53:18 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:36788 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbdBTMxP (ORCPT ); Mon, 20 Feb 2017 07:53:15 -0500 X-AuditID: b6c32a35-f79d66d000001a37-ec-58aae6aab4ae From: Bartlomiej Zolnierkiewicz To: Arnd Bergmann Cc: Tomi Valkeinen , Jyri Sarha , LABBE Corentin , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fbdev: ssd1307fb: include linux/gpio/consumer.h Date: Mon, 20 Feb 2017 13:52:54 +0100 Message-id: <1839834.0emLzaqV2B@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170217144226.2250882-1-arnd@arndb.de> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42LZdlhTT3fVs1URBv0f2S3+TjoGJP5WWnR3 drBanOj7wGpxedccNov182+xObB5/P41idFj56y77B7Hb2xn8vi8SS6AJYrLJiU1J7MstUjf LoEr49PMS0wF+9gqlrxex9TAeJS1i5GTQ0LAROLAygUsELaYxIV769m6GLk4hAR2MErsmXKF BcJpZ5JY9/4sE0zH9q5PUIk5jBKvVnewQjhfGSV2ru1nBKliE7CSmNi+CswWEVCUmPriGTNI EbPARkaJo3fWgS0XFnCRWDvtP9hyFgFVie9dk9m7GDk4eAU0Jf5MFQcJiwp4SWzZ1w62mVPA VGLplNNg5bwCghI/Jt8Ds5kF5CX27Z/KCmHrSJw9to4RZJeEwCJ2iWXXjjCDzJQQkJXYdIAZ 4gMXiZ0zp0HZwhKvjm9hh7ClJVb9uwX15XRGie2/JSDmbGaUWLV7AlSRtcTh4xehlvFJvPva wwoxn1eio00IwvSQWNMrDVHtKNE6/TwTJHw6gOHz9yPLBEb5WUhemIXkhVlIXljAyLyKUSy1 oDg3PbXYsMBQrzgxt7g0L10vOT93EyM4fWiZ7mCccs7nEKMAB6MSD2/D7JURQqyJZcWVuYcY JTiYlUR4Pz1eFSHEm5JYWZValB9fVJqTWnyIUZqDRUmcl9VgYoSQQHpiSWp2ampBahFMlomD U6qBMbuvdJGHGeOV7nb7nsmhIf8iRG2unP/hJLv5lea+NmaGZV1xt5IMmX6wZiREc0RWZbR7 WxXzupim5nJrPr1dv/32nvAdaZfkJqbOcdJzeLVkyZ0Jk0+2JbX+dk49y9Xz7+LZZ4GS4UdO ZuYsn5vN97lS/fcuDvGsspzE371PJA0tdj7gY7+oxFKckWioxVxUnAgA4QPg8RsDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsVy+t9jQd2Vz1ZFGLxtUrL4O+kYu8Xfv5UW 3Z0drBYn+j6wWlzeNYfNYv38W2wObB6/f01i9Ng56y67x/Eb25k8Pm+SC2CJcrPJSE1MSS1S SM1Lzk/JzEu3VQoNcdO1UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dglvGp5mX mAr2sVUseb2OqYHxKGsXIyeHhICJxPauTywQtpjEhXvr2boYuTiEBGYxSszd/osNJCEk8JVR Ys9BUxCbTcBKYmL7KkYQW0RAUWLqi2fMIA3MAhsZJfZ+fAk2VVjARWLttP9gU1kEVCW+d01m 72Lk4OAV0JT4M1UcJCwq4CWxZV87E4jNKWAqsXTKaRaIxV2MEid+rQDr5RUQlPgx+R6YzSwg L7Fv/1RWCFtLYv3O40wTGIHORCibhaRsFpKyBYzMqxglUguSC4qT0nMN81LL9YoTc4tL89L1 kvNzNzGC4+mZ1A7Gg7vcDzEKcDAq8fA2zF4ZIcSaWFZcmXuIUYKDWUmE99PjVRFCvCmJlVWp RfnxRaU5qcWHGE2BHpzILCWanA+M9bySeEMTcxNzYwMLc0tLEyMlcd7G2c/ChQTSE0tSs1NT C1KLYPqYODilGhgX27l/nSG0RI7L7o70p+UB60+d+FSQe4mxWyu4zKaWs2d1fsntKzPzAp9t sOqcb3jwKkutyCPNZj8tZpUfl+ucp/I8mxBnxFU27UOV6PeNH255Na+5VbjZasnzMK9YvqdP eR49DWVm9429ZielnHM+Z5ZclNIBt7p1DPOtTmtJtn9W3jFbeL4SS3FGoqEWc1FxIgCBz3rA vQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170220125257epcas1p23e4be2fe66606724481b01cf9671b028 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170217144238epcas4p1bb3d59ce932e9ce12e4078268538933e X-RootMTR: 20170217144238epcas4p1bb3d59ce932e9ce12e4078268538933e References: <20170217144226.2250882-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday, February 17, 2017 03:41:42 PM Arnd Bergmann wrote: > Changing this driver to the gpiod API requires the use of the > new-style header, depending on the configuration: > > drivers/video/fbdev/ssd1307fb.c: In function 'ssd1307fb_probe': > drivers/video/fbdev/ssd1307fb.c:569:15: error: implicit declaration of function 'devm_gpiod_get_optional';did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration] > drivers/video/fbdev/ssd1307fb.c:570:11: error: 'GPIOD_OUT_LOW' undeclared (first use in this function) > > Fixes: 72db33355c14 ("fbdev: ssd1307fb: Start to use gpiod API for reset gpio") > Signed-off-by: Arnd Bergmann Applied, thanks for fixing this. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics