From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755801AbcHTAlY (ORCPT ); Fri, 19 Aug 2016 20:41:24 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:55723 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754617AbcHTAlX (ORCPT ); Fri, 19 Aug 2016 20:41:23 -0400 From: "Rafael J. Wysocki" To: Srinivas Pandruvada Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, peterz@infradead.org, x86@kernel.org, bp@suse.de, sudeep.holla@arm.com, ak@linux.intel.com, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, alexey.klimov@arm.com, viresh.kumar@linaro.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, lenb@kernel.org, tim.c.chen@linux.intel.com, paul.gortmaker@windriver.com, jpoimboe@redhat.com, mcgrof@kernel.org, jgross@suse.com, robert.moore@intel.com, dvyukov@google.com, jeyu@redhat.com Subject: Re: [PATCH 05/11] acpi: cppc: Allow build with ACPI_CPU_FREQ_PSS config Date: Sat, 20 Aug 2016 02:46:06 +0200 Message-ID: <18399184.AAFNDR2hqb@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.8.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1471559812-19967-6-git-send-email-srinivas.pandruvada@linux.intel.com> References: <1471559812-19967-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1471559812-19967-6-git-send-email-srinivas.pandruvada@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, August 18, 2016 03:36:46 PM Srinivas Pandruvada wrote: > Some newer x86 platforms have support for both _CPC and _PSS object. So > kernel config can have both ACPI_CPU_FREQ_PSS and ACPI_CPPC_LIB. So remove > restriction for ACPI_CPPC_LIB to build only when ACPI_CPU_FREQ_PSS is not > defined. > Also for legacy systems with only _PSS, we shouldn't bail out if > acpi_cppc_processor_probe() fails, if ACPI_CPU_FREQ_PSS is also defined. > > Signed-off-by: Srinivas Pandruvada > --- > drivers/acpi/Kconfig | 1 - > drivers/acpi/processor_driver.c | 5 ++++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 445ce28..c6bb6aa 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -227,7 +227,6 @@ config ACPI_MCFG > config ACPI_CPPC_LIB > bool > depends on ACPI_PROCESSOR > - depends on !ACPI_CPU_FREQ_PSS > select MAILBOX > select PCC > help > diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c > index 0553aee..0e0b629 100644 > --- a/drivers/acpi/processor_driver.c > +++ b/drivers/acpi/processor_driver.c > @@ -245,8 +245,11 @@ static int __acpi_processor_start(struct acpi_device *device) > return 0; > > result = acpi_cppc_processor_probe(pr); > - if (result) > + if (result) { > +#ifndef CONFIG_ACPI_CPU_FREQ_PSS > return -ENODEV; > +#endif > + } if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS)) return -ENODEV; would look better. > > if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver) > acpi_processor_power_init(pr); > Thanks, Rafael