From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28CC01D8E1D for ; Wed, 16 Oct 2024 13:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729086001; cv=none; b=jB2RkU2f5L0MAE7P7y8B7/epoyHMZVLOhFUTNNNjNVWAFTUQDDDzAp5o+cOZJC/e2LZWV58wlzmwlAEhzMZmzUsAqjTT2XwggeSOROerodV9L3+WUNlOlXUVuynz20tlMgwc3ga+VTrH14TyHQTZcSu3dEE4/yDX5zztn8EyxSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729086001; c=relaxed/simple; bh=CH8Z2vUGmqSOv8MdEEAfce6v4Ceq6JjaXoXH43jMqsg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IBWGnhGZQoAW6vBBz+fIPDexcr0jMbgOuRKnVaDZ369zqRFhheHHZg0pgEdKv6N6IGRrtWH1VV5dw7yGnuwFNlWmoPZx+YCcpwMLJPr7VOKinKad60bRsfAxyZBC5Zz+QN2UYHTIjmNIClAJrhjaj5pHBlpNIqifgWVI9nnNwAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GY0rAtI1; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GY0rAtI1" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5c9454f3bfaso7236756a12.2 for ; Wed, 16 Oct 2024 06:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729085998; x=1729690798; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9Gtc/wvZtgZRYhU7nCyuDdZx7Qqo7TOKN4gjIik7fZg=; b=GY0rAtI1qPDTf5lMMPuU6QUZDYKr2mASZozpq0t0qfzcwDzWKyXRzHTA1+8l3ajjLf a6kul5DJRw48mlssDBmEWFGrtJctgjD0FLOsnApjaKE7xqmGbw70kDvdfuUKJg02W5Jy CIbVqhJxac+ZOAFIlh6QQQIneTyPMN/szAcCCDZO9mAjnLxigyYv+dM61S++bDo2RwDp dfKsacjHcxt0WWOMR8VRzPHgA1bba20LJPdDxYcglH3nvlFamncGSAy+MMaxlHfYwtNR a85l4SIqKp2hgI4veCgC5ipnMHpQNWb5WLtMFddIHYJxVLPEvCD0N8OEgxIGy7oIpAxC 0SSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729085998; x=1729690798; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9Gtc/wvZtgZRYhU7nCyuDdZx7Qqo7TOKN4gjIik7fZg=; b=MfjpgYAHisR/6QNbNiuFVdyKXKRrFbn0NmwVt6QoS/w87Bu8PeJ0wKB9xkM5SVCNnB +kSQKphDsYsZh1yFKZZURy8vY+3R5XIxChTIOrqqSVIFMs210Z2VljpSN9CYGqbHDgwx 1ZMh56QtmIFvNgYg5VbGFQZdOeYH8n4/h6nVRJ8tTf+YRilsVMJrBpy8tbpSl7GkmBQ5 xnbwG5KVmq1Lq/n+HdL9t0q3uqxcoLd5WV7JBR1/HYBNDydQeC3ZbVETK3y3c9mD9BUV BorMNznLEPDgWyEej++Pq/kErhTJyH7+xnaSg+2S1Xf+ELx1dueXaEto2D244UVrWrIX 5jhg== X-Forwarded-Encrypted: i=1; AJvYcCVgKP/Pj1zgPCjwSiEdrpEuuO1n2GOyOFSsFn4tsIHWyooHh1NOWa2fEZwgq3ALlUqX0jlGxPBV0a84M8c=@vger.kernel.org X-Gm-Message-State: AOJu0YwNnGSXfyAyLY9LiHyIECd57OslFWwp9lMe4GyDpDBiSPUvzzym Bo+VPNPE3Ca6Rpb5SFektKaVXJnX8WECARPnAr79wK4ucv2lQaivP97ww/SUiHM= X-Google-Smtp-Source: AGHT+IFAfsjHoVSlLzL1ZP/h9wEBchAr7uDR6VPsl4lgA/a6ZqvM2Wm8rkF3wN5KH+JSqUuZ0s+N6Q== X-Received: by 2002:a17:907:7ba8:b0:a9a:1778:7024 with SMTP id a640c23a62f3a-a9a1778712cmr810115566b.20.1729085998546; Wed, 16 Oct 2024 06:39:58 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a29844899sm186338766b.178.2024.10.16.06.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 06:39:57 -0700 (PDT) Date: Wed, 16 Oct 2024 16:39:54 +0300 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Colin Ian King , Tomi Valkeinen , Mauro Carvalho Chehab , Andy Shevchenko , Sakari Ailus , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] media: i2c: ds90ub960: Fix missing return check on ub960_rxport_read call Message-ID: <18412b95-7d34-4a80-940b-e5fc5bec3ec9@stanley.mountain> References: <20241002165329.957739-1-colin.i.king@gmail.com> <20241016094111.7f5e899a@foz.lan> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016094111.7f5e899a@foz.lan> On Wed, Oct 16, 2024 at 09:41:11AM +0200, Mauro Carvalho Chehab wrote: > Em Wed, 2 Oct 2024 17:53:29 +0100 > Colin Ian King escreveu: > > > The function ub960_rxport_read is being called and afterwards ret is > > being checked for any failures, however ret is not being assigned to > > the return of the function call. Fix this by assigning ret to the > > return of the call which appears to be missing. > > > > Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver") > > Signed-off-by: Colin Ian King > > No Cc: stable. Please follow the submission rules for fixes as stated > at: > Documentation/process/stable-kernel-rules.rst > > In summary, all patches containing fixes shall have a Cc stable. There > are rules there for the very few exceptions where a patch is not meant > to be backported: > > Cc: # reason goes here, and must be present > I don't think this patch belongs in stable. It's doesn't fix a real life bug, it's just static checker stuff. I also don't think we should forbid it from going to stable if it's required as a dependency to backport a different patch. regards, dan carpenter