From: Paul Mackerras <paulus@samba.org>
To: Nick Andrew <nick@nick-andrew.net>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
davem@davemloft.net
Subject: Re: [LMB][1/2] Fix some whitespace and other formatting issues, use pr_debug
Date: Sun, 13 Apr 2008 22:31:52 +1000 [thread overview]
Message-ID: <18433.64824.293863.930250@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20080412162940.GB29599@tull.net>
Nick Andrew writes:
> On Sat, Apr 12, 2008 at 03:20:59PM +1000, Paul Mackerras wrote:
> > + pr_debug("\n reserved.cnt = 0x%lx\n", lmb.reserved.cnt);
>
> This will only output an empty line at KERN_DEBUG level and the rest
> will be at default_message_loglevel. Problem is fixed my my patch in msg
> <20080412161733.24882.30930.stgit@marcab.local.tull.net>
>
> However, is a blank line in the log necessary?
No, and in fact the whole routine is probably not necessary any more.
Paul.
prev parent reply other threads:[~2008-04-13 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 5:20 Paul Mackerras
2008-04-12 16:29 ` Nick Andrew
2008-04-13 12:31 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18433.64824.293863.930250@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=nick@nick-andrew.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®