From: Zaslonko Mikhail <zaslonko@linux.ibm.com>
To: Tom Rix <trix@redhat.com>, akpm@linux-foundation.org, iii@linux.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/zlib: remove redundation assignement of avail_in dfltcc_gdht()
Date: Mon, 30 Jan 2023 10:29:17 +0100 [thread overview]
Message-ID: <1844e345-eb71-3b0b-aa1d-7b71575e534d@linux.ibm.com> (raw)
In-Reply-To: <20230128165048.1245792-1-trix@redhat.com>
On 28.01.2023 17:50, Tom Rix wrote:
> cppcheck reports
> lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment of 'avail_in' to itself. [selfAssignment]
> size_t avail_in = avail_in = strm->avail_in;
>
> Only setting avail_in once is needed.
>
> Fixes: aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel zlib_deflate")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> lib/zlib_dfltcc/dfltcc_deflate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/zlib_dfltcc/dfltcc_deflate.c b/lib/zlib_dfltcc/dfltcc_deflate.c
> index 80924f067c24..b732b6d9e35d 100644
> --- a/lib/zlib_dfltcc/dfltcc_deflate.c
> +++ b/lib/zlib_dfltcc/dfltcc_deflate.c
> @@ -62,7 +62,7 @@ static void dfltcc_gdht(
> {
> deflate_state *state = (deflate_state *)strm->state;
> struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE(state)->param;
> - size_t avail_in = avail_in = strm->avail_in;
> + size_t avail_in = strm->avail_in;
>
> dfltcc(DFLTCC_GDHT,
> param, NULL, NULL,
Acked-by: Mikhail Zaslonko <zaslonko@linux.ibm.com>
prev parent reply other threads:[~2023-01-30 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 16:50 Tom Rix
2023-01-29 19:07 ` Ilya Leoshkevich
2023-01-30 9:29 ` Zaslonko Mikhail [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1844e345-eb71-3b0b-aa1d-7b71575e534d@linux.ibm.com \
--to=zaslonko@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=iii@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®