From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D936EC77B7F for ; Tue, 16 May 2023 08:29:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231613AbjEPI3K (ORCPT ); Tue, 16 May 2023 04:29:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231490AbjEPI3H (ORCPT ); Tue, 16 May 2023 04:29:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C4861FE9 for ; Tue, 16 May 2023 01:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684225705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4LrwsQpkNzKQ73ySEswNaQqCDWSvOkZL+SFTwTYbhpM=; b=Pb+od5HJdB3d8TB38hoA/FkjMKY/vQ5fp2ZDZC+DH7i2sQIgFdUV+Cn5BuC2P9pEev6voQ IXmJ8toJ+uUelOlwXNN39TKKp49xAgFjYGnwMcBxcRBfNMlZEzGVhjOZ42s0LzURTffyOh IbD4GvQjQUFCkGfTy1jAnvreGsU68Nc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-u3PbJbvIO9qfJoDBlN9eBw-1; Tue, 16 May 2023 04:28:19 -0400 X-MC-Unique: u3PbJbvIO9qfJoDBlN9eBw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f4ef4bf00dso29549015e9.1 for ; Tue, 16 May 2023 01:28:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684225698; x=1686817698; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4LrwsQpkNzKQ73ySEswNaQqCDWSvOkZL+SFTwTYbhpM=; b=OlrS6yjIsvqVLig4WlmkY4NDPFGuYftpJjQud7cxZu0lU0M6h9p8k5aTWwzBLJlRM/ 2YXP6b7Mz+5CXjti1ZvaU9P1r3LyPCPHW7hPx0hz/yj9xEI+1TP6jqZwVUFs2MO8wBhh DuM3ZWp7xuI+EsTbHnnZ0mkwjMQ7JySrl3M5M3dSePpQfmcP00+QrQghsiJDEXjCa/9S DrQSVNemaBxtjLN3aK6vv20Avxh4dKqGNjK9WeiLVxgY7sFbi400P6q7Tygs62eVe0Cs q+WS/uz48Y2VahC2aqh9975t67m/n2Rdmee6sWTe3P7GDI/qBdfU7WWB66EBtm1cTqZQ D9Gw== X-Gm-Message-State: AC+VfDy8COpWG2XqCz/J0H0PrWbeVZk0ctuDb+n1lY0Giv8FI6L/ve8H gXxBvfXDoWTNB2ecKvIjxhJ0BVND3VFr/U2w892O62lGq5MPPVnNb0qoVZH/OwXU+xu0RwZgQw+ 76XxS9WeGApM7yv2i/w3d4NM0 X-Received: by 2002:a7b:cb97:0:b0:3f4:2c71:b9ad with SMTP id m23-20020a7bcb97000000b003f42c71b9admr19670887wmi.30.1684225698395; Tue, 16 May 2023 01:28:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5u32JaX9DoCvDoS+J6br6qwyFtkIX97b4yVh+uAVQvAOm++RWuF2owUBJbfmhSh0S5nzEg/g== X-Received: by 2002:a7b:cb97:0:b0:3f4:2c71:b9ad with SMTP id m23-20020a7bcb97000000b003f42c71b9admr19670863wmi.30.1684225697971; Tue, 16 May 2023 01:28:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c74f:2500:1e3a:9ee0:5180:cc13? (p200300cbc74f25001e3a9ee05180cc13.dip0.t-ipconnect.de. [2003:cb:c74f:2500:1e3a:9ee0:5180:cc13]) by smtp.gmail.com with ESMTPSA id v10-20020a05600c214a00b003f50e88ffb5sm1494416wml.24.2023.05.16.01.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 01:28:17 -0700 (PDT) Message-ID: <184c0b11-4f97-5872-5b25-ffd99eb6185d@redhat.com> Date: Tue, 16 May 2023 10:28:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 4/6] io_uring: rsrc: delegate VMA file-backed check to GUP Content-Language: en-US To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org, Jason Gunthorpe , John Hubbard References: <642128d50f5423b3331e3108f8faf6b8ac0d957e.1684097002.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <642128d50f5423b3331e3108f8faf6b8ac0d957e.1684097002.git.lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.05.23 23:26, Lorenzo Stoakes wrote: > Now that the GUP explicitly checks FOLL_LONGTERM pin_user_pages() for > broken file-backed mappings in "mm/gup: disallow FOLL_LONGTERM GUP-nonfast > writing to file-backed mappings", there is no need to explicitly check VMAs > for this condition, so simply remove this logic from io_uring altogether. > Worth adding "Note that this change will make iouring fixed buffers work on MAP_PRIVATE file mappings." I'll run my test cases with this series and expect no surprises :) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb