From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52B76368D42 for ; Fri, 29 May 2026 10:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780051513; cv=none; b=Wa1MvREkSson/9fXt7h3SvHxQVMdRs4wlAOdSJuuiBHuUTPGWw2lO05zQ2zO8MzjVkF/ZkzB4a40qeYYvK3YzrNvyN7/5z+AHX3YIFr8NAjEkDLP/HpRxjmSt5upDEnj5zI22Bzll0Nq9umz38tTynv9XUKXo9L8M4RZfk/dz3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780051513; c=relaxed/simple; bh=QuD01jJQSvE8R5xMlmBpQ+/u1Qt6bvUX20bJXOgIMzI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BIPU2EKcaooKj4rR1lgLrsyR9W2RNJhex/sFVxcrIm2kpVAINSOVDbEZr0zVe7+PY2FSGi+ApYCnOS77uykJBbBASQoOEnOQcYhcXbvepj9Y0vvTXd1KJdhb5u5L7ItIiQM75cQe+cCgivhxGJ+DIYSrmGjUKsIhupB0C/z+UVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kcWrQNX3; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kcWrQNX3" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-393b0fa758fso18011961fa.3 for ; Fri, 29 May 2026 03:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780051510; x=1780656310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xTiUmxm2e7d2JB+Cngp4w/ag6Fk1gY21uN8oBR9XC1k=; b=kcWrQNX3e3KO8yPWpgfvifF/oAj0BlruAgx1n0OUfs6Cxr1/vBpYDpqjarLI2E4ogu BItPCX8Q9cMAloU41ruXEVXEvXXag+mIScjaNEhkx9bq7+42THwRtOpGzOwoK+lEyu+5 qYinvPthzwz4+tcXX9wTqTXDux4nxo9PbdQs0fSgYjLTCz3Wi//qQ3+fFX4QN8NnzrOK ZiSp7b/3pwTXEJ3hoKhvqIBWv28uLA8OLMb31LT7lHe5wtl/EjjSYr74247IAKzzt1rx VOOxQDJg09Z1Vyf0cfM65QUszMZ5v78u57GBIneHKxVpk7QDoDbkZ5jfyqvCbIQ9O7dM a/kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780051510; x=1780656310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xTiUmxm2e7d2JB+Cngp4w/ag6Fk1gY21uN8oBR9XC1k=; b=NsyIdA6Uqf0bWtyK9On7qT9kBjGJlS1ApYkBDF3AvDKA1SBzEZiLq45vcL8gF2SzcK mNo37HUK7dN0cr0HUDrCtrKlCQA7tdT5GTcKoeOTlA8UZTq/g0ZMozemshMpHNrY+6Ez He22sYZDwckMcRdrTYU4u0GMwDZ1AAJUQLmkSVTq5MbTA7rBqpF37da/OS45H4+loTfG rB9BCxbohyl/cH6Io9UdGXlsDnHM4hzjDIjFjPwSRAVPrRKN71A9V387zpsQZXEdFXpy bGCd3HcLdPVn2a3mVgmw1xW5ruwRlOf+SR2VO/FUCltfrdq5VKHNxt/PmkDg7a8nDai3 2UJQ== X-Forwarded-Encrypted: i=1; AFNElJ+2gaXmf3mLC1ZEqTbrMyNbYrhszL0MIM9I+86BV/pHQx2ldjGC3Z6E+BDEr8wCY3BE9TDmfzWBJIg8zFQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyxhKTR/cXnflJFfaRdG7kXy+cRrA4OHc82tBELHYHUWKZeZ4R+ zXqO3d76CFLl7Yu04KSr+wCNRIYeJXrQIc4Od2Y6iTahWgM7B5+RQPU/ X-Gm-Gg: Acq92OHpIKAWDG1lGYJE/EDEfGq6dltsNEEaLFbgiSd2yMUfFSCYHjvYE8ZI0AHLzUq 6fMJrD8F7ceKjQDuDgZjsvMLdu74skdFMfMR2Wgcyp+YBi1IIZsI68rLOXZFLT1w7ePxsgEJTFk 3FjKeicSOukO2mhVJO3nlFZCchygrnqskPX6+nM5EzZtxnKefwWgtJQaqTjHvwhcEEuRURlA5Qy v0PsEmegRwgOMgsb3D8ywQQNriHXJU6OfJydOfOKyAUBSaPRnksqWz+Fi0N7G6/0WfcM+MEmNHC wjVV1cUw36zs2V9i0xHyFusTK9gGkm354XERiy389s3aCCLb2M1ka1dMa5thyMr80xP/o+ym247 wbne8GoGUwsivhhw80IDXANfRQIKSN7WWARWJdgtIwFKEEmxHfI3p9Hcw6LplpU0rq25Safdp84 bb6ILkFiI0UTQ6Hg2nRp8iXRR54Hso9cnx1eHAmxEJfK+kr6HgsAGofd8= X-Received: by 2002:a05:6512:a89:b0:5a1:4712:376a with SMTP id 2adb3069b0e04-5aa594bac11mr306522e87.8.1780051510356; Fri, 29 May 2026 03:45:10 -0700 (PDT) Received: from localhost.localdomain ([94.158.61.193]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa5b071d25sm205269e87.18.2026.05.29.03.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 03:45:07 -0700 (PDT) From: Stepan Ionichev To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] iio: light: isl29028: use devm_pm_runtime_enable() to fix probe error path Date: Fri, 29 May 2026 15:44:53 +0500 Message-Id: <184ef63b17643278dde6b9c15a9d6d1defd9d7c1.1780050609.git.sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit isl29028_probe() calls pm_runtime_enable() before iio_device_register(). If iio_device_register() fails, the probe returns directly without calling pm_runtime_disable(), leaving the runtime PM enable_count unbalanced. On the next probe attempt the kernel logs "Unbalanced pm_runtime_enable". Switch to devm_pm_runtime_enable() so the runtime PM state is unwound automatically on probe failure and on driver detach. Propagate its return value with a direct return on error. With runtime PM now managed by devres, isl29028_remove() no longer needs to call pm_runtime_disable() and pm_runtime_set_suspended() explicitly; drop those two calls. The remaining isl29028_clear_configure_reg() write does not depend on the runtime PM state. Signed-off-by: Stepan Ionichev --- drivers/iio/light/isl29028.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/isl29028.c b/drivers/iio/light/isl29028.c index 374bccad9119..4fb0262b214a 100644 --- a/drivers/iio/light/isl29028.c +++ b/drivers/iio/light/isl29028.c @@ -615,7 +615,9 @@ static int isl29028_probe(struct i2c_client *client) indio_dev->name = id->name; indio_dev->modes = INDIO_DIRECT_MODE; - pm_runtime_enable(&client->dev); + ret = devm_pm_runtime_enable(&client->dev); + if (ret) + return ret; pm_runtime_set_autosuspend_delay(&client->dev, ISL29028_POWER_OFF_DELAY_MS); pm_runtime_use_autosuspend(&client->dev); @@ -638,9 +640,6 @@ static void isl29028_remove(struct i2c_client *client) iio_device_unregister(indio_dev); - pm_runtime_disable(&client->dev); - pm_runtime_set_suspended(&client->dev); - isl29028_clear_configure_reg(chip); } -- 2.43.0