From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B26CC77B7C for ; Fri, 21 Apr 2023 16:45:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233104AbjDUQpr (ORCPT ); Fri, 21 Apr 2023 12:45:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbjDUQpo (ORCPT ); Fri, 21 Apr 2023 12:45:44 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07DADC16F for ; Fri, 21 Apr 2023 09:45:43 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9536df4b907so317691466b.0 for ; Fri, 21 Apr 2023 09:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682095541; x=1684687541; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vnmiQ74ckbmCHzXsPF3khRNGWST2xYm7Uu52Oav4tVM=; b=bhlmxaKOXCCVEKNTkJGozcV/ndNqekoqUUD7wxypm14K6Ajrke8cV04HxxIrorS9y2 owzU36YCZwD/rXEpGtDG9HXbPX3xEV4vLVpphDBJ5lOFg7rMNCmYIDVAHwGnhCVS/09V pwE7ocXB7vCj6zInIT2Cnaj1dSDiOdjkuQWTXhDi5zn5ALEuLy16bu3e7XBr5nhej5lG P4jNoB+jn8TSq+uUR6z5FF3vd0xt6CZRIMz08Y/88DyKtgHtJooTUT6Udm4qCjltuHc4 Ta9/SwC7vn8Rxqw4IzlKD7O+WO92WPp6iWN+CnioiHesps9l8sAcrJ2gxYzrkdsAyvtU iu+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682095541; x=1684687541; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vnmiQ74ckbmCHzXsPF3khRNGWST2xYm7Uu52Oav4tVM=; b=QZzWKv7MBGFnWZ/jZ0GNol0hK5Aar0kzoUIhXm8s/hq26XMNrsJT3/30bxxEsnLprn R7jYDxaA2GHEJVor6nHf7VyFRjGc8wwtIlA76phsvCcukXNGEuNMaO4iZFVFHLk4tU6I TlqKCwX7cJICpJREEgingFK6r9hc4YnXoaiKqfVONehlL1MUBfkofPfTFfqg5OQvGlQD 43n3OeExMpmz/B3EPj2A/c2ftjrhd6J5UI6IkBVDjvKEevMdXyNNWWWX43d1apepLwaH iezqFvv2qpxSrA6f4T8T1SwqkKBTkhXvG3OX8ywNvdRfQA3oM3uqAK3iRr975yQAwh3Y T7rg== X-Gm-Message-State: AAQBX9dTyYvUedkjS3XxJ7CELx2PJ68wXmRg2+l48+f5wJPHMt0WhZSB gHIJlDQszUc9ZS0W5tEpNKVG5Q== X-Google-Smtp-Source: AKy350a/T3bzp7xAMZP7/4+Ww9RoW1CuKYiHrcjkbeEKNilScolbMPJ2NDBvrevmBgyuxzGRAdY0DA== X-Received: by 2002:a17:907:2da7:b0:94e:d7b0:64d4 with SMTP id gt39-20020a1709072da700b0094ed7b064d4mr3220771ejc.47.1682095541531; Fri, 21 Apr 2023 09:45:41 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:687d:8c5:41cb:9883? ([2a02:810d:15c0:828:687d:8c5:41cb:9883]) by smtp.gmail.com with ESMTPSA id q27-20020a170906361b00b0094e1026bc66sm2295111ejb.140.2023.04.21.09.45.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 09:45:41 -0700 (PDT) Message-ID: <184f0a80-34bc-5ebf-58bb-82a310eb91f6@linaro.org> Date: Fri, 21 Apr 2023 18:45:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01 Content-Language: en-US To: Doug Anderson Cc: richard.leitner@linux.dev, Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Richard Leitner References: <20230201-innolux-g070ace-v2-0-2371e251dd40@skidata.com> <20230201-innolux-g070ace-v2-1-2371e251dd40@skidata.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/04/2023 18:37, Doug Anderson wrote: > Hi, > > On Fri, Apr 21, 2023 at 9:26 AM Krzysztof Kozlowski > wrote: >> >> On 21/04/2023 18:15, Doug Anderson wrote: >>> Hi, >>> >>> On Mon, Mar 13, 2023 at 12:51 AM wrote: >>>> >>>> From: Richard Leitner >>>> >>>> Add Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel compatible >>>> string. >>>> >>>> Acked-by: Krzysztof Kozlowski >>>> Signed-off-by: Richard Leitner >>> >>> nit: as I understand it, ordering of tags is usually supposed to be >>> chronological. You signed off on this patch before Krzysztof acked it, >>> so the SoB should be above. I'll fix that when applying. >> >> Some people agree with this... but b4 disagrees, so I would say the >> tools should implement the right process and right decisions. We should >> not be correcting the tools' output, unless the tools are not correct - >> then fix the tools. > > Ah, interesting. I checked and as far as I could tell Richard had > manually added the tag when sending v2, so I didn't assume it as a > tool-added tag. I'm happy to let "b4" be the canonical thing that says > what the order should be. > > OK, so I just tried this and I'm confused. I ran: > > b4 am -P_ 20230201-innolux-g070ace-v2-2-2371e251dd40@skidata.com > > ...and when I check the patch that b4 spits out my "Reviewed-by" tag > is _after_ the "Signed-off-by" tag, just like I asked for. > > Just in case Acked-by was somehow different than Reviewed-by, I went > back to the original version where you added the Acked-by: > > b4 am -P_ 20221118075856.401373-1-richard.leitner@linux.dev > > ...and, again, it matches the order that I thought was right. In other > words, the patch file generated says: > >> Signed-off-by: Richard Leitner >> Acked-by: Krzysztof Kozlowski We talk about `b4 trailers`, because the tag is applied by the submitter, not by the maintainer. > > Did I get something wrong in the above? Your `b4 am` will of course put the tag later, because it is you who applies the tag. Best regards, Krzysztof