From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757352AbcGJWPN (ORCPT <rfc822;w@1wt.eu>);
	Sun, 10 Jul 2016 18:15:13 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:54033 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757207AbcGJWPK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 10 Jul 2016 18:15:10 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Wan Zongshun <vw@iommu.org>, Russell King <linux@armlinux.org.uk>,
        devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
        jason@lakedaemon.net, Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
        Thomas Gleixner <tglx@linutronix.de>,
        Wan Zongshun <mcuos.com@gmail.com>
Subject: Re: [PATCH v2 09/10] Documentation: devicetree: Add dts description for nuc900
Date: Mon, 11 Jul 2016 00:17:52 +0200
Message-ID: <1850749.ap1S8Xq0fA@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1468136542-2656-2-git-send-email-vw@iommu.org>
References: <1468136542-2656-1-git-send-email-vw@iommu.org> <1468136542-2656-2-git-send-email-vw@iommu.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:cl7ARo7EzMQI4/ZtD8MfLgu2nhny8oFlccwv3iQKN4BxV8xJqa0
 deWPxuLNiSHPcGtwErqK64Ac3e+tS4YcfYq7rBB5zrjOS2nsDX1ZJz39xISGd9PFEzlqxnO
 gZyb0AP+AQ1SIhmTwi1fKl08drL0jua1Xb5DsnO32Nw1/OK61h88Xbvpj5zuC+GQH1AwPyp
 VOlKos/Y/fMHvLnvdSVxA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:WVUi/X230kA=:4/uD1bFuT2BRcoyRGADx6r
 ELbEi9nNWZNu/txm73Xi8S21rr4IV5L8SBbtV/7VhcrxfC/SyiIwEM8XCiEaEyDle740gxOAn
 fvT/TFPCcN6HfKMl9yON+LhpCmB+2VDuQqK+5sGdNyRj9mrWQ3HlTUo3We5Y9gI5Tpo8hwMk7
 L2BMToEqxRgDuyQ1Xupmlc+/imSbqH94mi+qaR4p4ylMjfmY83oPRz2lZrXLo1W3mMNYkdoqx
 89cnrcLh5+FD6A1jTzD3JO2eC+CE/olN69ag6zr0aj8QjRVmxMvdd4PDoVpbDt+tjbZoWj6As
 1C7N3yjlXNmjIhBD5DLcKad9D+ReVCVXbBwO9kZvkdHBTpwAD9RdLzwkeAqhiuABmdKgMV+TU
 nHWNHrVpfWzhiwryEZvJdGxm79wE8Bezt4d8hjKuVLG7sMxn3XLaFESP+G3ryYuLKS82fU9k5
 lul79Wvo3pEAU3NOQ6Phstk/WtNCPQPIWMyzDn3yo615ebUOgGqXHdBi/0VzAgPa4CBtyVQok
 EhmHdYnHb6RhnuYM7Ke6mbyeIyIKQ7RNQZD66lqsAW4ychptpu1eLnZdHaKrnNimE3USJnKkn
 ZkhlVKajHKN4WyHcD7UAND1RwAgaOHc67GiNAMO4pMdchHot+EUjZgIEnYZIjvMHdWqZloPVa
 fmUJhgcrO5UVf7Ldax6WHtidRjosx7p/UqHgybsZbF5v2ne2oyJuLgvJ/JnFW+C/H2WQ/VcWO
 loHzOCem89WwNagn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday, July 10, 2016 3:42:21 PM CEST Wan Zongshun wrote:
> +
> +Required properties:
> +- compatible : Should be "nuvoton,nuc970-tmr"
> +- reg : Address and length of the register set
> +- clocks : Reference on the timer input clock
> +- interrupts : Reference to the timer interrupt
> +
> +Example:
> +
> +tmr@0xb8001000 {

The name should be "timer", not "tmr", and the address should
not contain a leading "0x".

> +       compatible = "nuvoton,nuc970-tmr";
> +       reg = <0xb8001000 0x1000>;
> +       interrupts = <16>;
> +       clocks = <&clks TIMER0_GATE>,
> +       <&clks TIMER1_GATE>;
> +       clock-names = "timer0", "timer1";
> +};

The clocks/clock-names description does not match the example:
you only define a single clock in the required properties, but
have two separate inputs in the example. Please fix one or the
other.

	Arnd