From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D9E5153824 for ; Sat, 1 Feb 2025 15:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738423812; cv=none; b=mxaBFYKGHR3GwF8bgQ7jLfMfDDEffLWJi/JlawUKZBRu+ERw1qpMtwEHFjevIg55titOyx1gT1MPnGPfK6EmbdaeA/44aSi+XRh3SUP+/fxgXBuw+OTZBLo3SznurQBfA08vsVXlCXzt5Blu8C81zT7t3fBqB778JuOCd3LORPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738423812; c=relaxed/simple; bh=pneZuhBs75U2eZ3BgWmrLrinRinLHenz/os8RktLXi0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tzdjwNNd7QF/iQ0BSylEwgAIgn+5Y2yxPRz1wJaN2771yqHxlg5nikAmEcwdTaEZG6WfhvdtFAJPjCnVlpvp/Upuv4ngbD+TWl5kk6vCSNhQQO5yXIUiM78xTXf55xOE0giL4q3BJYYv6uIEOzeKtbs+32MAO1wLHFrGI7E8rZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VNh6dXk/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VNh6dXk/" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 511DVoBJ027308 for ; Sat, 1 Feb 2025 15:30:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mKelcYug8dBYhF4bh8maGBSgnMFBhqrXrUszluVow6I=; b=VNh6dXk/e5B3bEBg 11J57Jm2YcQUxLQgIlxA+esr9h/JCCwl6AobVeAlUF3m6BGo42y++YQijvU94/TY qf7voESjZu2y2P/DrNHQFTERk/UMpIbnQ2zZ2k6MsSSXNlkb90inAEnwJOrM8JZ/ Nh0WueBnc0UsrrhCZwp7BUFKUivCHgmc6UtB/LXdgL17fPLPoW+3Mv8UCOg/mPA5 hxdCV9sOhmJVwIiFKy2KwDeuakRSCn3KKAP62kft4yfhoD7TkYZCSG/MlF9GKWU9 KiY+wfXT6qRqGYcmPFEuP9+798Obi4jLi7p6GCidkKbMEEetxtXH5trGxJQBcf+L mPzEzQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44hd8yh33s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 01 Feb 2025 15:30:10 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7b6f28dc247so69560785a.3 for ; Sat, 01 Feb 2025 07:30:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738423799; x=1739028599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mKelcYug8dBYhF4bh8maGBSgnMFBhqrXrUszluVow6I=; b=gZnOMSZYR+QJ24vJT9pA8QZbTGUMoc6BiQ2dHUtT5KWyIxy9PiuVpts2fTu1++XiHd KGeWmnicsEQ0Nh6DyttLWQkj3dZgDGX3Oa972kyD+kdRvZ3kiYnTxV35yMEG6hOKCR5X fqTbKehIeaeX4J1IU6iXTvhwjFmq0e6u5+rzEtTtHLZdqej3w1J2UhEn1pOiyOfFSD4J 1IcOJMF0tIzTx2RHCtcd10rFgHbGvfGMvdrxjNkjvvDCkJI1CCIxjvrTEOX1kCwOvOka cm//KK7FNKhVTGAjMSb87nVVK2bIIK9GCvWHaDSP8CBXLjvoIV98wVEnEqcBDhTiRTqO +Gdw== X-Forwarded-Encrypted: i=1; AJvYcCXhhY8Q9Hr3IuKlNHw3nIwzzTHFed0PiYPvH9yAxLMyPvAbQRAuopgc4qfYitIKmgwONmceKNsAX5v7zRc=@vger.kernel.org X-Gm-Message-State: AOJu0YzLM19WLFa3Te8lFejfq8Sc1bunaoMnnQ9WuzRp0ekCJbvvOyLW 5/t9v/JYAuRVtnhp3jUyh2qCf8Iziprto2fyWoSqWQHqqn4UXrY7xdrlGSl1ESjfdLvO+2FBANL OAupAbCrvyUE04NCQtGK13Sc86I7jSU3prPr3j1koy1ynUSP/ncZSX1OEwCXukgY= X-Gm-Gg: ASbGncsNmWiijHlGptgGpuazKKsS7KplvbXTEP6FW7OogfCwSt4ORkEBLmBlxrrVOY2 WWeqZP7tQwMNG8OtwQlew++GYz6qVfo7OzjlqZ9lGLc2IcTnacrCpfAI7VfHzmljApXBkW4WcQs 0SPTBxLN884mRSCCGVLyTeZIK4OsZGvqkRwHrYwvA6inRBtP3rQd5O+yjcoqV+e0AecxHq3u3Xh Jfm2OamKE02KF3xKXEg6n0rlPH+IKdrYkyNoTpXpQb1hQJr2UI9G6VOdjFBW83bYK9Qxwt70ike lhtD7JOUzG35+IDerFDVVnfPyDoLaslFmOa0G8UwosA2i8iET+Iquk/wqg4= X-Received: by 2002:a05:620a:198d:b0:7b6:d273:9b4b with SMTP id af79cd13be357-7bffcd8bd6emr806168385a.10.1738423798791; Sat, 01 Feb 2025 07:29:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUc5dgjKTTrm6WQg/PcNfDDzUg4H36GWDA5vbZTnei8HHKXGpzYGIi+fzUPgn4xgwUNRY6Uw== X-Received: by 2002:a05:620a:198d:b0:7b6:d273:9b4b with SMTP id af79cd13be357-7bffcd8bd6emr806166685a.10.1738423798473; Sat, 01 Feb 2025 07:29:58 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dc72404537sm4585702a12.35.2025.02.01.07.29.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Feb 2025 07:29:57 -0800 (PST) Message-ID: <1850f3fb-bff6-4814-8f52-ea97ebef85b4@oss.qualcomm.com> Date: Sat, 1 Feb 2025 16:29:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: qrb2210-rb1: add Bluetooth support To: Dmitry Baryshkov , Marcel Holtmann , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Balakrishna Godavarthi , Rocky Liao , Bjorn Andersson , Konrad Dybcio Cc: linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20250201-rb1-bt-v1-0-ae896c4923d8@linaro.org> <20250201-rb1-bt-v1-4-ae896c4923d8@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250201-rb1-bt-v1-4-ae896c4923d8@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: MMFqolBuJy9qbeT72AdTFAErjc8o4gth X-Proofpoint-ORIG-GUID: MMFqolBuJy9qbeT72AdTFAErjc8o4gth X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-01_06,2025-01-31_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 mlxscore=0 malwarescore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502010135 On 1.02.2025 10:18 AM, Dmitry Baryshkov wrote: > Add support for the onboard WCN3950 BT/WiFi chip. Corresponding firmware > has been merged to linux-firmware and should be available in the next > release. > > Bluetooth: hci0: setting up wcn399x > Bluetooth: hci0: QCA Product ID :0x0000000f > Bluetooth: hci0: QCA SOC Version :0x40070120 > Bluetooth: hci0: QCA ROM Version :0x00000102 > Bluetooth: hci0: QCA Patch Version:0x00000001 > Bluetooth: hci0: QCA controller version 0x01200102 > Bluetooth: hci0: QCA Downloading qca/cmbtfw12.tlv > Bluetooth: hci0: QCA Downloading qca/cmnv12.bin > Bluetooth: hci0: QCA setup on UART is completed > > Signed-off-by: Dmitry Baryshkov > --- [...] > +&uart3 { > + interrupts-extended = <&intc GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>, > + <&tlmm 11 IRQ_TYPE_LEVEL_HIGH>; You need to either /delete-property/ interrupts, or define interrupts-extended in the base dt Though thinking about it years after, I'm not super impresesed that we have to hardcode what always is the UART_RX gpio manually, every time > + pinctrl-0 = <&uart3_default>; > + pinctrl-1 = <&uart3_sleep>; > + pinctrl-names = "default", "sleep"; > + status = "okay"; Please add a newline before status Konrad