From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D23CC1FF7DA for ; Thu, 9 Jan 2025 23:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736465837; cv=fail; b=g388vQsOtFwgKh9jgG3REsThh5W0lWjuP8pWlF44NTZFEk4OyoIIryNVHG8oyc8cUaGiKFOmUTyurr0rvVjFBbLtZmICBPPknUIGB/2EiF66E17mMMrtiwC6S6yZuklAFPn73JIuJJjfPQH/QDQMRA+NjpyK4+US2HD9Sqqyc8k= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736465837; c=relaxed/simple; bh=Lx23ibQTUj12sIBIPl5T0JtrsXPZpm7b0+x63XylA0k=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=r+lS+Q6IT86nLjejioHxeXYzG6BM0uUWIqZ4MGdgjP4yri7dtSS20Js6jRGHEHHtjIEbsRkWlja7zoRYQwARLtKjmBThxzTRywevdAJsmebRfRje7m3ZjlGW5JIMdwj7MQ3GIDob7cx6wNLZXS8evhtqZTBUJ7qWzI/ZLqh5FAc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=BKhdWF/M; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=EjkBEv6B; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="BKhdWF/M"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="EjkBEv6B" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 509LB3uT025913; Thu, 9 Jan 2025 23:37:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=3ILuhli8VWeIOHzJ8z1kUNMAMMqL2V4B1Uh4RFRXTvE=; b= BKhdWF/M/yX+CPup2wram1AgoTLJzWksev4jrFFhs59YcfbdTs8kZi/f/8E1EM+i mgifJHTxCIpMiWkhv49GFxmrY41cIxvnAY4mOInT473Y4bD5an0Ua9NzDf4Po5SW kq9Rx6FRWfIq5/xs2SgAlAsMo8zEmPU5EB4Ytkpp09Dc30avd1yuSzzwK0Xbv0E9 72JYh6tN0kbUwOPZ2u5Prjt3UKU3mvddU1EC/Fk+Ll0miNXQ3X6DjrIs9acSYMqn MMoGy/8ObHaOCol4wQX4UhFW8YxbzA8+Lt1dfPovpqO+DytNfr9aa0z9wkFjsf9Q W+B3PZqt/UFkp3j50+2+zg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 442my60ary-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Jan 2025 23:37:12 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 509LHpag010900; Thu, 9 Jan 2025 23:37:11 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2175.outbound.protection.outlook.com [104.47.59.175]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 43xuebkqu9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Jan 2025 23:37:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qZKDWSrhLSblOQO/NKBPCmOgLLgbHMevQwmFPNlMtkLeGo09KML8TKlqOD9qzg/z5Jk2vHOAYwpaCUnyiav8o3ZgQVtcQLVUXQpDedVuXQWJRHCKJzENNyjqoBgBIYnxBBJohd1o10fOUVpiHT7Rrru/ArIjjpuAXKblaQbPXicOsroS42wr1IniLeWWtlTDGpFVR+oB8m9c29sfGeIZMPTPqZE/yymJ3hlBY7ej9R4H6rw3hvW8+xBm7Y6SMISy+UfzHR99mQQAZ2PcUqvz3UnZae+LJRbjc5mBtR8QykmHBscO2xSoL/C5vBBMJCcZ4i7q6C1seOiDEKmsJqMSnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ILuhli8VWeIOHzJ8z1kUNMAMMqL2V4B1Uh4RFRXTvE=; b=tigaMEdNg9ffngNEnx00G6cOF9xxCQKYcZRR6c26VAXcuYEWkGZ7MSW5gbo/yswqjknqETqvmtH4daWFe2QTLCdpfx3TCa8mvjzd5uT2IguXH7apsIZRVN1191Zxw1oKclxAdcDnhAP0sOlgZaKfBCk1mrh1awRIxuLVX7iP2Efx0T5G1OsBYC9Ad/gqr8rpLPQVGbJ3gZTn4Zi/yxu40Ev3o5XlW2yTIz321lct9kgsb2wKYDfQJqVAn8NHL7xlf7sQU0TcFujcHnEL1Xncpsr26O5Y3SJQuHGMRf4YDYO15aClCCHoCR0OzD6+I+fxAz1EwT47RtFX1s3RcbqXcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ILuhli8VWeIOHzJ8z1kUNMAMMqL2V4B1Uh4RFRXTvE=; b=EjkBEv6BrmkXY2aiAgoDqQTL0CAu1SppT5EEd7CccKlXghw6SxglfyA3+mZ7st3gqFCMLZ5oGVyRWGZdznAQOOUrfTdjvUGB0SzKM4kne82SlBTXBrrvA2TmyXGFPdq9qx8X3KIqUMY7rXWQPuTXRa9hIlh6HGCkhODwCW09S74= Received: from CO1PR10MB4468.namprd10.prod.outlook.com (2603:10b6:303:6c::24) by PH8PR10MB6647.namprd10.prod.outlook.com (2603:10b6:510:221::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.11; Thu, 9 Jan 2025 23:37:08 +0000 Received: from CO1PR10MB4468.namprd10.prod.outlook.com ([fe80::485e:729e:c0a4:e562]) by CO1PR10MB4468.namprd10.prod.outlook.com ([fe80::485e:729e:c0a4:e562%5]) with mapi id 15.20.8335.010; Thu, 9 Jan 2025 23:37:08 +0000 Message-ID: <18515e86-ec37-4c8a-b14c-70c92f0532ec@oracle.com> Date: Fri, 10 Jan 2025 10:37:02 +1100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] workqueue: warn if delayed_work is queued to an offlined cpu. To: Tejun Heo Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org References: <20250109101829.2026320-1-imran.f.khan@oracle.com> Content-Language: en-US From: imran.f.khan@oracle.com In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR04CA0005.namprd04.prod.outlook.com (2603:10b6:208:d4::18) To CO1PR10MB4468.namprd10.prod.outlook.com (2603:10b6:303:6c::24) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR10MB4468:EE_|PH8PR10MB6647:EE_ X-MS-Office365-Filtering-Correlation-Id: d3297af0-139f-4675-8816-08dd31068857 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZkZWdGJDK1F5d2JrOHpDQk00NEdzNG9XaVB4OHc2SWt5R1VNUWpjVExFOTBR?= =?utf-8?B?VGJrM01vTlIyYUh3OFRMMnN1bEM4b0N5K3F0Nzk2ZmFsd0IzT2tkZnE1STlm?= =?utf-8?B?RURoY0ZTSEtMZnJGWWVHZWlwSmlYVHZlTmNmUkRucG1XekM3cE1FNmRZZ0RR?= =?utf-8?B?SjdTQzY0b1B1QkltUGJiYW0rOCtvS0J6Z0tQSm1OOGVhaHRaNjgxRmtWd0Vw?= =?utf-8?B?a1NQODV0TmpJRDlIaE5DWmRPNzBrZjJKbkZVckpzbklIaVcwZk9tN2h6UkNY?= =?utf-8?B?VVJoSFBnUjZyWWRyNTliZmNZV3dYS0hXZ3FIWVBEejZXTitqTDVFUzNzYkpz?= =?utf-8?B?NUM1cVdJaXI5OUJBRmh2bm11ZFdOZnQ3TDBQbkNFU21TdzhvQ0YwbDcrTytq?= =?utf-8?B?LzZOaHlTY0dhOUJEbXFweXczMjVYczVOeEd5aDc0OXcvT0RuUkg3Y1hMK0U1?= =?utf-8?B?VjUzc1pWUkpwcU51QVdEcWNrbEpPWVc2WHc0NFowUzk3SmZFMDhkL0prU3Mx?= =?utf-8?B?Szd1ODJQTk5CbXhnMUlDUkdpdStlOE42ZmpLL3FLaXUwZnR3MUNXMUNpMXF4?= =?utf-8?B?RitnbjRMQzVVd1o0blpSVVlJY2lLaDFsY280Y0REbit2WmdmbVZBY1VPSXI1?= =?utf-8?B?ejNwd1dDOGkrc2gzMkZvSGlzOWZxcXNqcDFOMU9rL3ZkMXhhODZrQ1IrUU9v?= =?utf-8?B?RDVHOFRqT2hMNnh0aFdXSXRpT3BLbXZ3dGxSK2Q1NS9KaWM2L0tpVE9KQjla?= =?utf-8?B?R0FYNkltQzNvMXdUYVp4aHVnaGtlMXNqbk9uUWFJY0huNmpEUDdFMkZkNXB5?= =?utf-8?B?dTVtbTRmaEtpTXk2TWU3WUFTR2VRQ1crZitmY05ZUWdNaUhRRXJPYVhrYXJ1?= =?utf-8?B?WUFMZHhOaXAwRXZpQzJXKzE3bDUrU3lkcmNvSEJMQWIxR1JoeFJuVlNJNEFk?= =?utf-8?B?dWI4c25yQjlUMlNTcStlRTJqQjFPNkc0UHRhc2c1UDVMRmVQQTF3MURMT2Fu?= =?utf-8?B?c3M0dmZLNnlId1JXUkFjeW1PalZ0dGFvbzQybHQzbWx0eHVYOS9uc3NMcmFv?= =?utf-8?B?R2FkWGhDc2gvbXIvdkxxUjBvbUVpL01FRXNsekE3aHdrS3ZZNnFqbi83MnZz?= =?utf-8?B?NGFKSUN3NEFwNWpLbFl0bVBFRTlWSjRsbzdzeTdqdU9PVUhVVGYvdXBLSFow?= =?utf-8?B?S2ExOUNOZkdNVHQ3bnpHNml5Mm42RVdXQ3BaRmUwRW1LOWVtb2FpMlRySURM?= =?utf-8?B?RjJwa0NWNUFadlFLeW54R2pWVXQ4dzZFbHZ6aXI3OVdJcDZyQVFLZ2VEWERJ?= =?utf-8?B?eVhMZ1hnN1EwdXNsaVBtZzFzTjJpS0RVVnF4SStvVXFvWFN5eWdabUZJYkNN?= =?utf-8?B?QUZtVU9nRFdIZUdmemVGaDBPNTUrOHBwRzZ1Y3BSdzJzRlRiNkZMbTQ1eVJa?= =?utf-8?B?YUxXOXo3TG9NYXAxM0tTMTRac000djBTR2xvalBVUFA4WkorTUZCRUpiY2E2?= =?utf-8?B?aElNU2l3OXJFNEp4elRUNFpOZllEK1BrOExSNVRodUxZclBoMDZDWEN6ZXhs?= =?utf-8?B?N3JtLzY0NGlGSzFFS29rUDh2QlMrbjhoVm9tWjNaWXFnOEc5cmNWVlh2T0x0?= =?utf-8?B?eDdSY2FkSTBYTkV0UExFaVdGcFdjVi9uQVFVNjFXQUx2YkgyUUZvMTlpa2xY?= =?utf-8?B?WUVtTE5welZEZ212ZkUwa1hrNVc1emIwbU4zTFZoTS9ZNjg1elhUbnNnSUJU?= =?utf-8?B?Z2dBc1oydTdwcTVXRStoUDhmamw4T2hmVmw4YlFQSmxNbW9ZUWxDZE5YVVA4?= =?utf-8?B?VGxmdFIxcHFTZHE2TVRCcHpPeVFLaXdIQStUdy9iOUtka2dnUUtDeVJ3TmJX?= =?utf-8?Q?CYupOWT/EpiBs?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4468.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWxBQ2lRYVpkb0FyKzM5eDZJRUV5SHN1Mm9OdUw4K1VFdFRjZlllY0Q2WFN2?= =?utf-8?B?aDFHTzNiMHlNM2ZSdm1rNjNLVi9tVG5md1YyTE1idjdpSXVIU3l6YjBHUThr?= =?utf-8?B?N1FIVUFja1lpMHVoOVhVVW92aXU4elZpcUwwbitnNUtJd0JOS1JVejJmZmJP?= =?utf-8?B?TWN4QVgwK0daZkJYS2U3Mzl3RUEvR0lHWTJIUXZ5U1dmV3R2NjF0S2k3Ynoz?= =?utf-8?B?TDBlVXd4WFJaalhCQXp2VStRUUdJaStNYUF5ZjIrRkFpZ2tvTzg2Q1lZZURS?= =?utf-8?B?SGtvL00raitBS2RHWHNHWTExaGlLR0dmL3pKdFNLeTVnM05obkMzcTl6Kzcw?= =?utf-8?B?dFplRHBNcTEveUtwUkVhbU44NjZ3aVFCSzZhUWV6NmE1L29PUkx5R2hlV0h5?= =?utf-8?B?MHlwc0F2S1U5UWV0dFJmak1hVkVPVndpMm5lRHFFR3VTSGt5S2VjY2VoTnE2?= =?utf-8?B?N1Z0cU5FQURZZGRHV0l0dFVwbUtGbGM5OEsrRHpmOUFXdTBnVW5ObjNTbWF5?= =?utf-8?B?eW93U09SdEFvTkFsaHA5Z2VTQlJuaHRSdDgveTJYMytRaE13U3h1UzVaeWxM?= =?utf-8?B?dWxOcXdSNXNueGFEY2g1eE9UazJURnYrRTVDQmFTVDNld3JjRTFDZ1lKenV6?= =?utf-8?B?REhRUFNwRFE0TkJ5ZnphTUl3cEJSQkZaRGQ2TDFPR1J3RkdBemNHcHMxYmlY?= =?utf-8?B?UVRhd3BKZFFoaFplb0dvMnllVHVLZkxwd1lnZEx3ZHI4VHphdjM0cmtpQVZP?= =?utf-8?B?VUFCelpmUzd0bVcxVzk3cE4yYlFacHV3NTBVVUpqTW1KNmpmTEFBc0sxOVpm?= =?utf-8?B?Q1JOblUyV2l0eFljaGdxbG5RaVl1eGZ5Sis4ZDM4aEpkTTRQbHhHNUswRmRX?= =?utf-8?B?Y29MaGI2bUNMWlBwL3pqZnc1TWxsaGNncGIrRXhTRVJUbndBaHZMS1ZiNmFr?= =?utf-8?B?NDJBV21mNjNUWUFicUdBa1oxdE83NUJadUw4eTduN0tuUGs5RTZNbWFubURP?= =?utf-8?B?REhkWUhKREQvQnhYV1dncitBNHFUajVzMElQbWxMVExQUFdpZFVxUFBOK2o0?= =?utf-8?B?QkR0UDFSWEZFNlN5WFkrSjhNM0F5dUp0WVZRSE8xS1RNZmNsdklQTnkvZkhZ?= =?utf-8?B?R2NsOVVBSU9nSysrNUxqMFBBZFpIVExhcDQ0SHpSWlAzMTZMN1hFbjcyMVZ5?= =?utf-8?B?ZDFSaXNza2MrK3JYYlkybEJoR2J1V3U1eVVkMTU4NW10c0JIUWRSUWFWd09E?= =?utf-8?B?aC81cDV0cDBrclc4NExBdkcreWppN3o5aDJBUStLL2dYQjloNWpPMmZkbk0r?= =?utf-8?B?VW1QVjZlclJ1SkJEclBkN1owYXVsa05MMFVvUitRdk9mNzNWVnNMQUlYUXFa?= =?utf-8?B?dzBvTGpTUzJ6OU9rNGNoRzFlNVpkMzMxUGRWd0Y5Rmw4WVV6S0dxV040ZXQw?= =?utf-8?B?Y3B6WjFQRFRQTGFxZWFidm1BYjhqOWUyTVBOV3plMzVqd1NMS0tLVDRIc0tW?= =?utf-8?B?WHpYWEZ4YzVJQlBxZHJwcnErMnc2SEZFRkRzamM0SVd0Q1VaUXlaR29JeG5W?= =?utf-8?B?bW4rL1RSQWZjREdwWkpyMHR5amY5bXB3aDVjdnlnci9WQjRZdUZUbDBQTitL?= =?utf-8?B?OXJ4dFNBOHV5d2I2Z05ldjJRYnB1K1J3M0EzdmpFMHZWN1kvRit5eU1ibXBD?= =?utf-8?B?YnJ6N0dEQ0VpSURDVWJ1ckppSkswRWhrNGd1RWJMVkJPSkxnTXVlaXlJVVll?= =?utf-8?B?TDBVQlFnKzBCTUo0V1NCL1pPOXVOeHFkYjZzR0hzTnBLY1ViMXNOb1dzeDdY?= =?utf-8?B?cFpxbnJkRkI1cVJtV3pzTnRqRndKd29LNnVXUnRpVW5jOHdUMnAyMUdSeGZU?= =?utf-8?B?RTlHTW1DWWJlQ2x6bW84NWxYcS9NREV5b0l3cGpaNmNwS3JrWnUzcGhJUXF3?= =?utf-8?B?MVlTdGcyTk5nbzlDT0N2ZjhPL1piZWxvTmc2cU9OYWN0bXluRHRLNnNtRVQ4?= =?utf-8?B?SWQ4ajVuNGs2S2Q1MVpRK29MQkdYT3FaUFl0bDJuL2RkclljVjh2a3NVbEtU?= =?utf-8?B?d0srd2s5c0NZTk1nb2Y5eitueXNIRXczOXlOUmRoRjRGMmhxQ29iSDFRT2cr?= =?utf-8?B?blN0QTJvWEJVMmdLaHJqK1dmdTRzT25hVXZVdmVkR3YzdHYxSGtJWXh5K2JK?= =?utf-8?B?aXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kFdVUWF7EGUslSTV9IYufaNayhit6eEBzMhSYbhahxcd+hl4EKiLJKZTRPo3qR7WTs0Y4s8G//hFX4TfH9Ismecr/LFDeGWoFRuKdFqUR8wfO3JsLgeNcu/T7it24dW+asvWUePDkJ1xJU7b3ikEOiDU1EAkcMLjcdsQSUW6ugWNZlpLqFudFwZJDCG2PvqNX62cZPpLljZ8T8NLpSttoImcsvyea7lh6A6JwNzDDMbc+YwGmF9te6C35pjMozzxe7DQRZLTTRWFID6gs/OzG0Eel/A6cISrUIfniKDG1LtNB4UlFO8R7+5o6PQDsmn0+LTb8CE66AtDy8LnnIiYWKEoLxgEhDCYPCb+1C0ZdThTAcbFpBzrAR4NTfSu0GXkQClqfvCzdZkDnPEC2YraxHfVhjcsr0xWxM76eZDg0CwaWXnyF30jPtJCcfcE8yiuHPMVHG01EvK4wVMoA9IkNH/HYARPZpiIqUNXLUBtaG6aapoZSwRwXGqmGf4Esoo6R0UiTf2ze+6SScXuEtxvAA5Y3IjcMHnMKTOCsfY+YcZD4PtazATKKvIdcizq7DqimZwzCsj2wT3FYtwp9wJst9vIq7c4tRjoX/HQoFNbRkw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3297af0-139f-4675-8816-08dd31068857 X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2025 23:37:08.5422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ujmX6ypQk0sijk6D1e2LVk/yaX11lNgGio59wxwD6/VOraIDZeinjgFeZje/CxEUOBXrrAemtxRUcS/i8ObjAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6647 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-09_10,2025-01-09_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501090185 X-Proofpoint-GUID: fCKcDAxdVdk7YD7U7Meyqrn4BmoOvJHk X-Proofpoint-ORIG-GUID: fCKcDAxdVdk7YD7U7Meyqrn4BmoOvJHk Hello Tejun, Thanks a lot for having a look. On 10/1/2025 8:08 am, Tejun Heo wrote: > On Thu, Jan 09, 2025 at 09:18:29PM +1100, Imran Khan wrote: >> delayed_work submitted to an offlined cpu, will not get executed, >> after the specified delay if the cpu remains offline. If the cpu >> never comes online the work will never get executed. >> checking for online cpu in __queue_delayed_work, does not sound >> like a good idea because to do this reliably we need hotplug lock >> and since work may be submitted from atomic contexts, we would >> have to use cpus_read_trylock. But if trylock fails we would queue >> the work on any cpu and this may not be optimal because our intended >> cpu might still be online. >> >> Putting a WARN_ON for an already offlined cpu, will indicate users >> of queue_delayed_work_on, if they are (wrongly) trying to queue >> delayed_work on offlined cpu. >> >> Signed-off-by: Imran Khan >> --- >> kernel/workqueue.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kernel/workqueue.c b/kernel/workqueue.c >> index 8e0bb3c608239..10878b5e3d74f 100644 >> --- a/kernel/workqueue.c >> +++ b/kernel/workqueue.c >> @@ -2508,6 +2508,7 @@ static void __queue_delayed_work(int cpu, struct workqueue_struct *wq, >> return; >> } >> >> + WARN_ON(cpu != WORK_CPU_UNBOUND && !cpu_online(cpu)); > > Can we use WARN_ON_ONCE() instead? > Yes we can. The reason I was using WARN_ON was that, if someone does this for multiple offlined CPU, we could see the warnings for each of them. I have sent a v2 of this patch with WARN_ON_ONCE. Also in v2, I have modified description of queue_delayed_work_on, similar to that of queue_work_on, to indicate why the caller should ensure that specified cpu is and remains online. Thanks, Imran > Thanks. >