From: Paul Mackerras <paulus@samba.org>
To: Eric B Munson <ebmunson@us.ibm.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] Keep 3 high personality bytes across exec
Date: Wed, 18 Jun 2008 16:12:44 +1000 [thread overview]
Message-ID: <18520.42844.509290.191269@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20080618060651.GA8251@us.ibm.com>
Eric B Munson writes:
> Currently when a 32 bit process is exec'd on a powerpc 64 bit host the values
> of the top three bytes of the personality are clobbered. This patch adds a
> check in the SET_PERSONALITY macro that will carry all the values in the top
> three bytes across the exec.
>
> Signed-off-by: Eric B Munson <ebmunson@us.ibm.com>
Your commit message needs to remind us what is in those bytes, and
tell us what bad things happen if we don't keep them, and what is the
benefit of keeping them. And if there are any user-visible aspects of
this change, they need to be flagged.
Paul.
next prev parent reply other threads:[~2008-06-18 6:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 6:06 Eric B Munson
2008-06-18 6:12 ` Paul Mackerras [this message]
2008-06-18 21:15 ` [RFC PATCH V2] " Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18520.42844.509290.191269@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=ebmunson@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®