Re: [NEW DRIVER V4 0/7] DA9058 PMIC - please comment on this new driver

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Friday, April 12, 2013 02:05:29 PM Anthony Olech wrote:
> This is submission attempt number 4 to have this driver included in
> the linux kernel source tree. This is the driver for the Dialog DA9058.
> 
> The DA9058 is a low power Power Management Integrated Circuit with extra
> functionality. It is a Multi Function Device controlled only from an I2C
> bus whose components can raise an interrupt request on a single IRQ line.
> 
> The driver for the DA9058 consists of a core (i2c) device driver that
> instantiates the individual component device drivers for:
> 
> adc - 5 ADC channels
> gpio - 2 available pins
> onkey - 1 device

I have exactly the same comment as ~6 month ago:

> On Wed, Aug 15, 2012 at 04:05:22PM +0100, Anthony Olech wrote:
> > This is the ONKEY component driver of the Dialog DA9058 PMIC.
> > This driver is just one component of the whole DA9058 PMIC driver.
> > It depends on the CORE component driver of the DA9058 MFD.
> > 
> > Signed-off-by: Anthony Olech <anthony.olech.opensource@diasemi.com>
> > Signed-off-by: David Dajun Chen <david.chen@diasemi.com>
> 
> This is almost exact copy of da9052_onkey, can they be merged together?
> 
> Thanks.

-- 
Dmitry