From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932638AbeCSKKk (ORCPT ); Mon, 19 Mar 2018 06:10:40 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:53712 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754923AbeCSKKi (ORCPT ); Mon, 19 Mar 2018 06:10:38 -0400 From: "Rafael J. Wysocki" To: Mario Limonciello Cc: linux-acpi@vger.kernel.org, LKML Subject: Re: [PATCH] power/hibernate: Make passing hibernate offsets more friendly Date: Mon, 19 Mar 2018 11:11:07 +0100 Message-ID: <1854392.I8WPNng6r5@aspire.rjw.lan> In-Reply-To: <1520333620-22342-1-git-send-email-mario.limonciello@dell.com> References: <1520333620-22342-1-git-send-email-mario.limonciello@dell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, March 6, 2018 11:53:40 AM CET Mario Limonciello wrote: > Currently the only way to specify a hibernate offset for a > swap file is on the kernel command line. > > Add a new /sys/power/disk_offset that lets userspace > specify the offset and disk to use when initiating a hibernate > cycle. > > Also split up the parsing routine to re-use the same code > for the /sys/power/resume and /sys/power/disk_offset parsing. > > Signed-off-by: Mario Limonciello Well, IMO /sys/power/resume and /sys/power/disk_offset would be confusingly similar after this patch. I wonder if adding a resume_offset sysfs attr to simply allow the value of resume offset alone to be passed to the kernel at run time (in addition to the command line) would work? Thanks!