From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F8F0E8FDC1 for ; Tue, 3 Oct 2023 22:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231950AbjJCWzB (ORCPT ); Tue, 3 Oct 2023 18:55:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbjJCWy6 (ORCPT ); Tue, 3 Oct 2023 18:54:58 -0400 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E80EDB4; Tue, 3 Oct 2023 15:54:55 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 185A63200B49; Tue, 3 Oct 2023 18:54:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 03 Oct 2023 18:54:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1696373692; x=1696460092; bh=2jVHXmEhNGnLoThDwRPTaiXQ4VgtqdFS0mA cLW+bbUo=; b=IFhkv836Ujjzz4C2Te8jaNK4yy5yagWg1P/KMPmBtP+4n2IQXBa BmL3DpoJYO2BiYOvgijAusiv/52+c83Q921gn4qrPC/03dVyvKOUUqIu4Azidibo sRA3I06mXeBlA1GANIpHRvDl94FVtkQOjEEwL43OlqysU43s3v8k9godLZQhXk6d mwx6s7htmDB8P3+tienqK8LriGaCCTllrpfJ3GojqbnJGCLRNsWjSj7EVJ3gYEFN m/Td9YaTngsxXGj4+tLli/NArQ09DPboAH7C7oMSB1NLnma1u/OYB7qHtlhaVtDW K/a1Ec2RmdC+NPWnZDjncviLe3SpooAnrig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1696373692; x=1696460092; bh=2jVHXmEhNGnLoThDwRPTaiXQ4VgtqdFS0mA cLW+bbUo=; b=egPLEMD8Ni268aQlNmn/ScE2MzX3hNgSvoVz75KIExlNmuMPNxw g60ujvzGsPgMQSmY7K5b3KPbors8ma0tP29W0gdl1/wLrsN3NZfje2IItjQlyTZV +oIG0Syv7SNFl2yomimmjRnw2bkqH+r+NoBda8F7y/c25t4N2IvkYJR6PGrNs1AR sT12oLzNTRXj3SMhZj6RbWDdGFo9EGO7CpEkrpFI9YNO8jVp1sSpHvCniAmZIuGS ymIPtBsL8rx/HVvdG33J7X4tYNUc2Xk4GqfmWOqbX9ekpBlicQLZG9T8b6gSuEXj RCELFVTHbzZglTF93G6wfihWJ1biZPxqL2A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfeekgdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepuegvrhhn ugcuufgthhhusggvrhhtuceosggvrhhnugdrshgthhhusggvrhhtsehfrghsthhmrghilh drfhhmqeenucggtffrrghtthgvrhhnpeffjeevfeefjefghfefhfeiueffffetledtgffh hfdttdefueevledvleetfeevtdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsggvrhhnugdr shgthhhusggvrhhtsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: id8a24192:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Oct 2023 18:54:51 -0400 (EDT) Message-ID: <18552fc7-184c-4bc7-9154-c885fae06d31@fastmail.fm> Date: Wed, 4 Oct 2023 00:54:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [resend PATCH v2 0/2] virtiofs submounts that are still in use forgotten by shrinker To: Krister Johansen Cc: Miklos Szeredi , linux-fsdevel@vger.kernel.org, Miklos Szeredi , linux-kernel@vger.kernel.org, German Maglione , Greg Kurz , Max Reitz References: <97163cdf-ab2c-4fb8-abf2-738a4680c47f@fastmail.fm> <20231003164823.GA1995@templeofstupid.com> Content-Language: en-US, de-DE From: Bernd Schubert In-Reply-To: <20231003164823.GA1995@templeofstupid.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/3/23 18:48, Krister Johansen wrote: > On Tue, Oct 03, 2023 at 12:18:42AM +0200, Bernd Schubert wrote: >> >> >> On 10/2/23 17:24, Krister Johansen wrote: >>> Hi, >>> I recently ran into a situation where a virtiofs client began >>> encountering EBADF after the client / guest system had an OOM. After >>> reproducing the issue and debugging, the problem is caused by a >>> virtiofsd submount having the nodeid of its root dentry fogotten. This >>> occurs because it borrows the reference for this dentry from the parent >>> that is passed into the function. >> >> >> Sorry, I didn't forget you, just didn't manage to review the 2nd version >> yet. Will definitely do this week. > > Thanks; I appreciate the feedback you've provided so far. > >> Please also note that there will be merge conflicts with atomic open patches >> from Dharmendra/me. Although probably not too difficult to resolve. > > Sure. I'm happy to reparent, resolve those conflicts, re-test, and send > another revision when we're ready. I suspect there are going to be > additional changes requested on the v2. With that in mind, I'll hold > off for the moment unless it is going to cause headaches for you. I certainly also didn't mean that you should check for merge conflicts, it was more an annotation that it might come up - depending on the merge order. Please don't stop to do improvements, resolving merge conflicts shouldn't be difficult. I'm going to add you to the atomic open patch series to keep you updated, if you don't mind. > > For the atomic-open-revalidate changes: should I be working from what's > on the list? This is the most recent patchset I see: > > https://lore.kernel.org/linux-fsdevel/20230920173445.3943581-1-bschubert@ddn.com/ > > I found a 6.5 relative tree of yours on GitHub by following the libfuse > pull request, but nothing that seemed in sync with fuse/for-next. I don't think there are conflicts with fuse-next right now, but I can check. Thanks, Bernd