mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fix icom serial compile.
Date: Tue, 22 Jul 2008 11:56:46 +1000	[thread overview]
Message-ID: <18565.15966.954687.565824@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20080721230742.4649b94a@lxorguk.ukuu.org.uk>

Alan Cox writes:

> On Mon, 21 Jul 2008 18:13:55 -0400
> Dave Jones <davej@redhat.com> wrote:
> 
> > drivers/serial/icom.c: In function 'recv_interrupt':
> > drivers/serial/icom.c:733: error: 'struct uart_info' has no member named 'tty'
> > 
> > Signed-off-by: Dave Jones <davej@redhat.com>
> 
> NAK. Already in the ttydev tree but not yet gone to Linus

Well then why on earth did you send Linus the patch that broke stuff
in the first place?  That seems like a pretty unfriendly act to me.

Paul.

  parent reply	other threads:[~2008-07-22  1:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-21 21:16 Fix serial_txx9 compile Dave Jones
2008-07-21 22:00 ` Alan Cox
2008-07-21 22:27   ` Dave Jones
2008-07-21 22:34     ` Alan Cox
2008-07-21 22:13 ` Fix icom serial compile Dave Jones
2008-07-21 22:07   ` Alan Cox
2008-07-22  1:25     ` Stephen Rothwell
2008-07-22  2:05       ` Alan Cox
2008-07-22  2:41         ` Dave Jones
2008-07-22 10:46           ` Alan Cox
2008-07-22  1:56     ` Paul Mackerras [this message]
2008-07-22  2:06       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18565.15966.954687.565824@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®