From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Hector Martin <marcan@marcan.st>,
Aditya Garg <gargaditya08@live.com>, <aspriel@gmail.com>,
<hante.meuleman@broadcom.com>, <kvalo@kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <lina@asahilina.net>,
<franky.lin@broadcom.com>
Cc: Orlando Chamberlain <redecorating@protonmail.com>,
<brcm80211-dev-list@broadcom.com>,
<brcm80211-dev-list.pdl@broadcom.com>,
<linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Asahi Linux <asahi@lists.linux.dev>
Subject: Re: [PATCH 1/2] brcmfmac: Use separate struct to declare firmware names for Apple OTP chips
Date: Mon, 02 Jan 2023 19:27:31 +0100 [thread overview]
Message-ID: <18573bd1a38.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> (raw)
In-Reply-To: <9c5bdb0a-0877-ed16-f09f-164a9dab16d4@marcan.st>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
On January 2, 2023 4:15:41 PM Hector Martin <marcan@marcan.st> wrote:
> On 02/01/2023 23.40, Aditya Garg wrote:
>> From: Aditya Garg <gargaditya08@live.com>
>>
>> Commit 'dce45ded7619' added support for 89459 chip pcie device. It uses the
>> BRCM4355 chip which is also found in Apple hardware. However this commit
>> causes conflicts in the firmware naming between Apple hardware, which
>> supports OTP and other non-Apple hardwares. So, this patch makes these
>> Apple chips use their own firmware table so as to avoid possible conflicts
>> like these in the future.
>
> I think my reply to Arend flew over your head.
>
> My point was that I'd rather have the Broadcom/Cypress people actually
> answer my question so we can figure out how to do this *properly*,
> instead of doing "safer-but-dumb" things (like this patch) because we
> just don't have the information to do it properly.
Fair enough. Can you accurately (re)state your question and I will try to
answer it.
Regards,
Arend
> - Hector
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
next prev parent reply other threads:[~2023-01-02 18:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 7:46 [REGRESSION] Wi-Fi fails to work on BCM4364B2 chips since kernel 6.1 Aditya Garg
2023-01-02 8:21 ` Linux kernel regression tracking (#info)
2023-01-02 10:27 ` Thorsten Leemhuis
2023-01-02 8:47 ` Hector Martin
2023-01-02 8:57 ` Aditya Garg
2023-01-02 9:13 ` Hector Martin
2023-01-02 14:40 ` [PATCH 1/2] brcmfmac: Use separate struct to declare firmware names for Apple OTP chips Aditya Garg
2023-01-02 14:41 ` [PATCH 2/2] brcmfmac: Add PCIe ID of BCM4355 chip found on T2 Macs Aditya Garg
2023-01-02 14:46 ` Aditya Garg
2023-01-03 2:08 ` kernel test robot
2023-01-02 14:46 ` [PATCH v2 1/2] brcmfmac: Use separate struct to declare firmware names for Apple OTP chips Aditya Garg
2023-01-02 14:48 ` [PATCH v2 2/2] brcmfmac: Add PCIe ID of BCM4355 chip found on T2 Macs Aditya Garg
2023-01-02 15:15 ` [PATCH 1/2] brcmfmac: Use separate struct to declare firmware names for Apple OTP chips Hector Martin
2023-01-02 15:24 ` Aditya Garg
2023-01-02 18:27 ` Arend Van Spriel [this message]
2023-01-03 3:55 ` Hector Martin
2023-01-03 13:30 ` Arend van Spriel
2023-01-03 13:46 ` Hector Martin
2023-01-04 9:32 ` Arend van Spriel
2023-01-03 19:59 ` Zzy Wysm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18573bd1a38.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=asahi@lists.linux.dev \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=franky.lin@broadcom.com \
--cc=gargaditya08@live.com \
--cc=hante.meuleman@broadcom.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=pabeni@redhat.com \
--cc=redecorating@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®